Merge lp:~nbessi-c2c-deactivatedaccount/account-invoice-report/7.0-better-x-path into lp:~account-core-editors/account-invoice-report/7.0

[Nicolas Bessi - Camptocamp]

See https://code.launchpad.net/~account-core-editors/account-invoice-report/7.0-add-html-note/+merge/143241/comments/310401 for more details

Tested on today stable (18.01.2013)

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

LGTM

review: Approve (code review, no test)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

LGTM

review: Approve

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Can somebody merge this one please.

Regards

Nicolas

[Stefan Rijnhart (Opener) (stefan-opener)]

Will do so

[Niels Huylebroeck (red15)]

Hold it, the intent is good, the xpath won't work afaik.

You have the following arch:

<field name="invoice_line">
   <tree string="Invoice Lines">
      ...
   </tree>
</field>

Thus your xpath of "//tree[@name='invoice_line']" cannot match, the tree itself does not have a name, it's the field above the tree that has the name !

This is why I suggested "//field[name='invoice_line']/tree" instead.

If the current xpath actually worked for you (tested) I will withdraw my remark but would be interested in knowing where my xpath understanding went wrong ?

review: Needs Fixing

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Hello,

Well your right.

I was tricked because updating the addon made a silent exception. But if you install it from scratch it wont install.

I will provide a fix soon.

Regards

Nicolas

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

I revert the commit now as it induce a bug.

Nicolas

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

FYI if you update the server to tag 7.0 update of addon will now also throw an exception.

Regards

Nicolas

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Just corrected the MP.

Nicolas

[Niels Huylebroeck (red15)]

Thanks for handling it this quick, looks find to me now.

review: Approve

[Stefan Rijnhart (Opener) (stefan-opener)]

Approve and merged. Good catch, Niels!

review: Approve

=== modified file 'invoice_webkit/view/invoice_view.xml'
--- invoice_webkit/view/invoice_view.xml	2013-01-16 08:23:31 +0000
+++ invoice_webkit/view/invoice_view.xml	2013-01-18 11:57:21 +0000
@@ -69,7 +69,7 @@
       <field name="model">account.invoice</field>
       <field name="inherit_id" ref="account.invoice_form"/>
       <field name="arch" type="xml">
-        <xpath expr="//tree[@name='invoice_line']" position="attributes" >
+        <xpath expr="//field[@name='invoice_line']/tree" position="attributes" >
           <attribute name="editable" eval="False"/>
         </xpath>
       </field>