Merge lp:~nathwill-deactivatedaccount-deactivatedaccount/checkbox/lp988260 into lp:checkbox
Proposed by
Nathan Williams
Status: | Merged |
---|---|
Merged at revision: | 1560 |
Proposed branch: | lp:~nathwill-deactivatedaccount-deactivatedaccount/checkbox/lp988260 |
Merge into: | lp:checkbox |
Diff against target: |
15 lines (+4/-1) 1 file modified
scripts/network_check (+4/-1) |
To merge this branch: | bzr merge lp:~nathwill-deactivatedaccount-deactivatedaccount/checkbox/lp988260 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Nathan Williams (community) | Needs Resubmitting | ||
Review via email:
|
Description of the change
wrap call(command) in try/catch to handle zenity absence (lp: #988260)
To post a comment you must log in.
Thanks for your contribution to checkbox!
This code looks fine, I do have a request for the message you show when zenity is not found. The current message doesn't give much of a clue about why zenity is important, and people may confuse this with the result of the test.
I wonder if you could update it so it explains more clearly why zenity is needed and what the consequence will be. Maybe something like "unable to report test results since zenity is not installed" may work better. I leave it to your criteria.
Thanks again!