Merge lp:~nathanael-naeri/deja-dup/fix-1660174-1660224-1660342 into lp:deja-dup/34
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Michael Terry | ||||||||||||
Approved revision: | 1571 | ||||||||||||
Merged at revision: | 1571 | ||||||||||||
Proposed branch: | lp:~nathanael-naeri/deja-dup/fix-1660174-1660224-1660342 | ||||||||||||
Merge into: | lp:deja-dup/34 | ||||||||||||
Diff against target: |
55 lines (+16/-2) 1 file modified
tests/shell (+16/-2) |
||||||||||||
To merge this branch: | bzr merge lp:~nathanael-naeri/deja-dup/fix-1660174-1660224-1660342 | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Terry | Approve | ||
Review via email: mp+317041@code.launchpad.net |
Commit message
Set HOME to the test environment /tmp/dd-<temp> (fixes LP:1660174), include a trash can in the test environment (fixes LP:1660224), and setup XDG Special User Directories in the test environment (fixes LP:1660342).
Description of the change
I propose three improvements to the test shell, to make the test environment more similar to the user's environment, and therefore facilitate testing: set HOME to the test environment /tmp/dd-<temp> (fixes LP:1660174), include a trash can in the test environment (fixes LP:1660224), and setup XDG Special User Directories in the test environment (fixes LP:1660342).
The changes are limited to the file tests/shell. Please review the bug reports and the changes in this file to make sure I didn't mess things up (I don't think so and I hope not).
Thank you! This looks nice and looks like it works just fine.