lp:~natefinch/juju-core/jameinel-1.18-panic-parsing-jenv-1312136
- Get this branch:
- bzr branch lp:~natefinch/juju-core/jameinel-1.18-panic-parsing-jenv-1312136
Branch merges
- Juju Engineering: Pending requested
-
Diff: 112 lines (+47/-16)3 files modifiedjuju/api.go (+26/-16)
juju/apiconn_test.go (+20/-0)
juju/export_test.go (+1/-0)
Related source package recipes
Related bugs
Related blueprints
Branch information
Recent revisions
- 2278. By Nate Finch
-
refactor a little bit to make the code easier to read, and make sure we handle *all* errors
- 2277. By John A Meinel
-
moving the error vars into the blocks that use them allows the compiler to notice that we weren't using err before
- 2276. By John A Meinel
-
Add a test that would panic() without it, but at least asserts we get a proper err
- 2275. By John A Meinel
-
turn the Debugf into a Warningf so that users have a chance to know that their config is broken.
- 2274. By John A Meinel
-
actually handle config.New errors. (bug #1312136)
If there was an error parsing foo.jenv it was getting ignored and causing a panic
later on. This removes the panic and logs the error. - 2273. By Curtis Hovey
-
[r=jameinel] Increment juju stable to 1.18.2
Increment juju stable version and win installer to 1.18.2.
- 2272. By John A Meinel
-
[r=jameinel] testing/
filetesting: preserve bzr file-ids filetesting was backported from trunk to 1.18 using diff+patch rather than a bzr merge that would preserve its file identifiers. That means that when merging from 1.18 => trunk all those files look like duplicated files. This patch just fixes up the Bazaar indentifiers so that they match, which should allow easier merging between 1.18 and trunk in the future.
As this is a metadata only change (no code changes), I'm going to self approve this.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:~go-bot/juju-core/trunk
