Code review comment for lp:~natefinch/juju-core/053-nolog-jenv

Revision history for this message
Andrew Wilkins (axwalk) wrote :

On 2014/05/28 20:15:40, nate.finch wrote:
> Please take a look.

(Just echoing my reply to juju-dev)

I think it'd be better just to sanitise the output by using the
EnvironProvider.SecretAttrs method. Then we get to see the .jenv minus
secrets, which may be helpful in debugging.

Also, we log the bootstrap script, and that contains the full bootstrap
config. That needs to be sanitised (or suppressed) as well. See
RunConfigureScript, cloudinit/sshinit/configure.go; perhaps change that
to Tracef?

https://codereview.appspot.com/98580048/

« Back to merge proposal