lp:~natefinch/juju-core/028-nopending

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2173. By Nate Finch on 2013-12-23

Change test for pendingupload to be not true instead of false, since it can be nil, which should be treated as false

2172. By Dimiter Naydenov on 2013-12-20

[r=dimitern] cmd/juju: status using the API

Add status cmd to api with state access fallback

Current progress on having `juju status` use the api. Moves the
existing code to a resurrected state/statecmd file. This is
exposed both through the api, and as a fallback to accessing
state directly.

The status tests now pass, but moving some testing down a layer
or two would probably be a good plan.

Is there anything else required for a status first pass?

dimitern: I pulled Martin's branch lp:~gz/juju-core/status_api,
merged trunk and resolved conflicts, also fixed a couple of
tests, but no other changes are made. All tests pass, and
I also did a successful live test on EC2. Original CL is
at: https://codereview.appspot.com/40350043/, and has already
2 LGTMs.

https://codereview.appspot.com/38420046/

R=dimitern, rogpeppe

2171. By Roger Peppe on 2013-12-20

[r=rogpeppe],[bug=1252799] state: AddMachine revamp continues

We bring the exported State methods closer to the underlying
implementation.

The old interface is still visible in the API, which we can't
easily change for backward compatibility reasons.

As a drive-by fix, we also remove state.Machine.TxnRevno because it's
unnecessary.

https://codereview.appspot.com/37850043/

2170. By Nate Finch on 2013-12-20

[r=natefinch] mongo replicaset configuration

These changes encompass an API for setting up and controlling a mongo replicaset directly through mgo. In order to facilitate testing, the code under testing to set up a test mongo server was refactored to allow it to be used for multiple mongo servers (previously it used a lot of package global variables).

2169. By Andrew Wilkins on 2013-12-20

[r=axwalk] Introduce BootstrapContext

Environ.Bootstrap now takes an additional
parameter, a *BootstrapContext. This is a
structure that permits access to the
caller's context. It currently comprises
stdio handles and a signal handler.

Fixes #1237736

https://codereview.appspot.com/38240043/

2168. By Ian Booth on 2013-12-20

[r=wallyworld] Make auth keys processing more robust

Auth keys are stored in the environment as a string.
A common utility function is used to extract the keys
from this string so that empty lines and comments
are ignored.

https://codereview.appspot.com/44420044/

2167. By Andrew Wilkins on 2013-12-20

[r=axwalk] environs/manual: ignore stderr in detection

SSH warnings were mucking up series/hw detection.

https://codereview.appspot.com/44200043/

2166. By Tim Penhey on 2013-12-19

[r=thumper] Add gnuflag support for []string

Add a StringsValue type for gnuflag parsing.

This allows comma separated values to be used as a single arg, and they are
split up into the []string passed in to the NewStringsValue function.

https://codereview.appspot.com/39150045/

2165. By Dimiter Naydenov on 2013-12-19

[r=dimitern],[bug=1216830] cmd/juju: upgrade-charm via the API + 1.16 compat

This introduces one new API call: ServiceGetCharmURL,
which is used by the upgrade-charm command to detect
new or 1.16-compatible mode of execution (when the
API server does not support the new API call, it's
assumed 1.16 mode should be used).

Also, now upgrade-juju does not use directly at all,
and goes entirely through the API (except in 1.16 mode).

https://codereview.appspot.com/44230045/

R=fwereade

2164. By Dimiter Naydenov on 2013-12-19

[r=dimitern] cmd/juju: deploy using the API + 1.16 compat.

juju deploy starts to use the API only, if possible.
Older API servers, not supporting charm uploads are
detected and the old 1.16-compatible code with a
direct state connection is executed.

In addition to that, bug #1216830 is fixed (no juju.Conn
usage in state/apiserver antmore), which required some
refactoring, namely moving conn.DeployService and also
conn.AddUnits out of juju.Conn and into a juju/deploy.go,
taking a *state.State as argument.

https://codereview.appspot.com/44240045/

R=rogpeppe