Merge lp:~nataliabidart/wsgi-oops/restore-bz2-serializer into lp:wsgi-oops

Proposed by Natalia Bidart
Status: Merged
Approved by: Eric Casteleijn
Approved revision: 44
Merged at revision: not available
Proposed branch: lp:~nataliabidart/wsgi-oops/restore-bz2-serializer
Merge into: lp:wsgi-oops
Diff against target: 21 lines
1 file modified
canonical/oops/wsgi.py (+2/-2)
To merge this branch: bzr merge lp:~nataliabidart/wsgi-oops/restore-bz2-serializer
Reviewer Review Type Date Requested Status
Eric Casteleijn (community) Approve
Rick McBride (community) Approve
Review via email: mp+14414@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Restoring Bz2 serializer for wsgi apps.

Revision history for this message
Rick McBride (rmcbride) wrote :

Looks good!

review: Approve
Revision history for this message
Eric Casteleijn (thisfred) wrote :

Looks good, is there any way I can run tests for wsgi-oops locally? (have not done any reviews for it before)

review: Approve
Revision history for this message
Rick McBride (rmcbride) wrote :

Eric Casteleijn wrote:
> Review: Approve
> Looks good, is there any way I can run tests for wsgi-oops locally? (have not done any reviews for it before)

'make test' works in that particular package.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'canonical/oops/wsgi.py'
2--- canonical/oops/wsgi.py 2009-10-26 02:02:15 +0000
3+++ canonical/oops/wsgi.py 2009-11-04 12:20:26 +0000
4@@ -33,7 +33,7 @@
5
6 from storm.tracer import install_tracer, remove_tracer_type
7
8-from canonical.oops.serializer import OOPSRFC822Serializer
9+from canonical.oops.serializer import OOPSBz2Serializer as OOPSSerializer
10 from canonical.oops.oops import (
11 OOPS, OOPSLog, OOPSMetaData, OOPSLoggingHandler )
12 from canonical.oops.stormtracer import OOPSStorm, OOPSStormTracer
13@@ -60,7 +60,7 @@
14 else:
15 root_logger.addHandler(OOPSLoggingHandler())
16 fh = debug and sys.stderr or None
17- self.serial = OOPSRFC822Serializer("appserver", oops_dir, fh=fh)
18+ self.serial = OOPSSerializer("appserver", oops_dir, fh=fh)
19
20 def __call__(self, environ, start_response):
21 """

Subscribers

People subscribed via source and target branches