Ubuntu One Control Panel

Merge lp:~nataliabidart/ubuntuone-control-panel/urgent into lp:ubuntuone-control-panel

  1. urgent
  2. Merge into trunk
Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 134
Merged at revision: 133
Proposed branch: lp:~nataliabidart/ubuntuone-control-panel/urgent
Merge into: lp:ubuntuone-control-panel
Diff against target: 11 lines (+1/-1)
1 file modified
ubuntuone/controlpanel/gtk/gui.py (+1/-1)
To merge this branch: bzr merge lp:~nataliabidart/ubuntuone-control-panel/urgent
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
dobey (community) Approve
Review via email: mp+57318@code.launchpad.net

Commit message

- Setting the unity's urgent prop only if available (LP: #755185).

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

I think we need to use False instead of None in this check. Otherwise even if False, it will switch to volumes page, even when it shouldn't.

review: Needs Fixing
lp:~nataliabidart/ubuntuone-control-panel/urgent updated
134. By Natalia Bidart

Check not only for urgent availability but also proper boolean value.

Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1 yikes?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/controlpanel/gtk/gui.py'
2--- ubuntuone/controlpanel/gtk/gui.py 2011-04-07 22:59:52 +0000
3+++ ubuntuone/controlpanel/gtk/gui.py 2011-04-12 13:12:33 +0000
4@@ -1734,7 +1734,7 @@
5 if not USE_LIBUNITY:
6 return
7 entry = Unity.LauncherEntry.get_for_desktop_id(U1_DOTDESKTOP)
8- if entry.props.urgent:
9+ if getattr(entry.props, 'urgent', False):
10 self.switch_to('volumes')
11 entry.props.urgent = False
12

Subscribers

People subscribed via source and target branches