Merge lp:~nataliabidart/ubuntuone-control-panel/nothing into lp:ubuntuone-control-panel

Proposed by Natalia Bidart
Status: Merged
Approved by: Roberto Alsina
Approved revision: 211
Merged at revision: 211
Proposed branch: lp:~nataliabidart/ubuntuone-control-panel/nothing
Merge into: lp:ubuntuone-control-panel
Diff against target: 11 lines (+1/-0)
1 file modified
data/qt/controlpanel.ui (+1/-0)
To merge this branch: bzr merge lp:~nataliabidart/ubuntuone-control-panel/nothing
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+73865@code.launchpad.net

Commit message

- Show an empty page until credentials result is ready (LP: #839795).

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1 trivial

review: Approve
Revision history for this message
Roberto Alsina (ralsina) wrote :

Seems to get stuck with the overlay displayed.

review: Needs Fixing
Revision history for this message
Roberto Alsina (ralsina) wrote :

> Seems to get stuck with the overlay displayed.

No it doesn't

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/qt/controlpanel.ui'
2--- data/qt/controlpanel.ui 2011-08-25 21:22:21 +0000
3+++ data/qt/controlpanel.ui 2011-09-02 18:23:25 +0000
4@@ -250,6 +250,7 @@
5 </item>
6 </layout>
7 </widget>
8+ <widget class="QWidget" name="empty"/>
9 <widget class="SignInPanel" name="signin"/>
10 </widget>
11 </item>

Subscribers

People subscribed via source and target branches