Merge lp:~nataliabidart/ubuntuone-control-panel/new-colors into lp:ubuntuone-control-panel

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 303
Merged at revision: 296
Proposed branch: lp:~nataliabidart/ubuntuone-control-panel/new-colors
Merge into: lp:ubuntuone-control-panel
Diff against target: 366 lines (+87/-87)
4 files modified
data/qt/images.qrc (+1/-0)
data/qt/preferences.ui (+3/-0)
data/qt/side_widget.ui (+22/-1)
data/qt/ubuntuone.qss (+61/-86)
To merge this branch: bzr merge lp:~nataliabidart/ubuntuone-control-panel/new-colors
Reviewer Review Type Date Requested Status
Robert Grant (community) Approve
Roberto Alsina (community) Approve
Review via email: mp+98912@code.launchpad.net

Commit message

- Modified stylesheet to use the new colours from brand, and to also ease
  the reading of white text (LP: #956077).
- Fixed the gap tab outlines (LP: #822629).

Description of the change

To post a comment you must log in.
302. By Natalia Bidart

Clean up.

Revision history for this message
Roberto Alsina (ralsina) wrote :

+1 pretty

review: Approve
303. By Natalia Bidart

Also remove the right padding for the help_button to match 0 left padding when
focused.

Revision history for this message
Robert Grant (rtgrant) wrote :

+1 Nice

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'data/external_icon_dark_grey.png'
2Binary files data/external_icon_dark_grey.png 1970-01-01 00:00:00 +0000 and data/external_icon_dark_grey.png 2012-03-22 20:32:25 +0000 differ
3=== modified file 'data/qt/images.qrc'
4--- data/qt/images.qrc 2012-03-15 01:25:08 +0000
5+++ data/qt/images.qrc 2012-03-22 20:32:25 +0000
6@@ -2,6 +2,7 @@
7 <qresource prefix="/">
8 <file>../banner.png</file>
9 <file>../computer.png</file>
10+ <file>../external_icon_dark_grey.png</file>
11 <file>../external_icon_orange.png</file>
12 <file>../external_icon_white.png</file>
13 <file>../icon.png</file>
14
15=== modified file 'data/qt/preferences.ui'
16--- data/qt/preferences.ui 2012-03-14 18:37:40 +0000
17+++ data/qt/preferences.ui 2012-03-22 20:32:25 +0000
18@@ -95,6 +95,9 @@
19 <property name="orientation">
20 <enum>Qt::Vertical</enum>
21 </property>
22+ <property name="sizeType">
23+ <enum>QSizePolicy::Minimum</enum>
24+ </property>
25 <property name="sizeHint" stdset="0">
26 <size>
27 <width>40</width>
28
29=== modified file 'data/qt/side_widget.ui'
30--- data/qt/side_widget.ui 2012-03-14 15:11:19 +0000
31+++ data/qt/side_widget.ui 2012-03-22 20:32:25 +0000
32@@ -20,7 +20,16 @@
33 <property name="spacing">
34 <number>40</number>
35 </property>
36- <property name="margin">
37+ <property name="leftMargin">
38+ <number>0</number>
39+ </property>
40+ <property name="topMargin">
41+ <number>0</number>
42+ </property>
43+ <property name="rightMargin">
44+ <number>10</number>
45+ </property>
46+ <property name="bottomMargin">
47 <number>0</number>
48 </property>
49 <item>
50@@ -83,6 +92,9 @@
51 <property name="text">
52 <string notr="true">Install</string>
53 </property>
54+ <property name="wordWrap">
55+ <bool>true</bool>
56+ </property>
57 </widget>
58 </item>
59 </layout>
60@@ -125,6 +137,9 @@
61 <property name="text">
62 <string notr="true">Sign In</string>
63 </property>
64+ <property name="wordWrap">
65+ <bool>true</bool>
66+ </property>
67 </widget>
68 </item>
69 </layout>
70@@ -164,6 +179,9 @@
71 <property name="text">
72 <string notr="true">Select sync folders</string>
73 </property>
74+ <property name="wordWrap">
75+ <bool>true</bool>
76+ </property>
77 </widget>
78 </item>
79 </layout>
80@@ -203,6 +221,9 @@
81 <property name="text">
82 <string notr="true">Sync, stream, share!</string>
83 </property>
84+ <property name="wordWrap">
85+ <bool>true</bool>
86+ </property>
87 </widget>
88 </item>
89 </layout>
90
91=== modified file 'data/qt/ubuntuone.qss'
92--- data/qt/ubuntuone.qss 2012-03-21 18:17:34 +0000
93+++ data/qt/ubuntuone.qss 2012-03-22 20:32:25 +0000
94@@ -7,7 +7,7 @@
95 */
96
97 QMainWindow {
98- background-color: #aea79f;
99+ background-color: #adadad;
100 }
101
102 QWidget {
103@@ -16,6 +16,7 @@
104
105 QFrame {
106 border: none;
107+ border-color: #333333;
108 }
109
110 UbuntuOneWizard,
111@@ -23,13 +24,12 @@
112 background: white;
113 border-radius: 5px;
114 border-style: solid;
115- border-color: #939389;
116 border-width: 1px;
117 min-height: 90px;
118 }
119
120 QFrame#frame_greeting {
121- margin 0px;
122+ margin: 0px;
123 padding-left: 15px;
124 padding-top: 10px;
125 padding-right: 10px;
126@@ -39,7 +39,6 @@
127 QFrame#frame_status,
128 QFrame#frame_storage {
129 border-style: dotted;
130- border-color: #939389;
131 border-left-width: 1px;
132 padding: 10px;
133 min-width: 40px;
134@@ -47,24 +46,21 @@
135
136 QFrame#account_separator {
137 border-style: dotted;
138- border-color: #939389;
139 border-bottom-width: 1px;
140 }
141
142 QFrame#frm_box { /*The Loading Overlay frame.*/
143- background: #ffffff;
144+ background: white;
145 border-radius: 5px;
146 border-style: solid;
147- border-color: #939389;
148 border-width: 1px;
149 color: white;
150 min-height: 100px;
151 }
152
153-SideWidget {
154+SideWidget { /* is a QFrame, so border color is already set */
155 background-color: white;
156 border-style: dotted;
157- border-color: #939389;
158 border-right-width: 1px;
159 color: white;
160 min-height: 100px;
161@@ -100,7 +96,7 @@
162
163 QPushButton:enabled {
164 background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1,
165- stop: 0 #ffffff,stop: 1.0 #e6e6e6);
166+ stop: 0 white, stop: 1.0 #e6e6e6);
167 color: #333333;
168 border-color: #999999;
169 }
170@@ -111,7 +107,7 @@
171
172 QPushButton:enabled:hover {
173 background: qlineargradient(x1: 0, y1: 0, x2: 0, y2: 1,
174- stop: 0 #ffffff,stop: 1.0 #ededed);
175+ stop: 0 white, stop: 1.0 #ededed);
176 }
177
178 QPushButton:enabled:pressed {
179@@ -169,10 +165,9 @@
180 background: transparent;
181 border: none;
182 text-decoration: underline;
183- color: white;
184- padding-left: 10px;
185- padding-right: 25px;
186- background-image: url(:/external_icon_white.png);
187+ padding-left: 2px; /* 2px border buffer when focused */
188+ padding-right: 15px;
189+ background-image: url(:/external_icon_dark_grey.png);
190 background-repeat: no-repeat;
191 background-position: right;
192 background-origin: margin;
193@@ -185,8 +180,8 @@
194 padding-bottom: 100%;
195 /* end of hack */
196 /* Compensate for border so text doesn't move */
197- padding-left: 8px;
198- padding-right: 23px;
199+ padding-left: 0px;
200+ padding-right: 13px;
201 }
202
203 GoToWebButton#share_publish_button {
204@@ -213,51 +208,65 @@
205 padding-right: 23px;
206 }
207
208+GoToWebButton#edit_profile_button,
209+GoToWebButton#edit_services_button,
210+GoToWebButton#get_more_space_button {
211+ padding-left: 8px;
212+ padding-right: 25px;
213+ background-image: url(:/external_icon_white.png);
214+ background-repeat: no-repeat;
215+ background-position: right;
216+ background-origin: margin;
217+}
218+
219+QTabWidget {
220+ border-bottom-left-radius: 5px;
221+ border-bottom-right-radius: 5px;
222+ border-style: solid;
223+ padding: 10px;
224+}
225+
226+QTabWidget::pane {
227+ border-bottom-left-radius: 5px;
228+ border-bottom-right-radius: 5px;
229+ border-top-right-radius: 5px;
230+ border-style: solid;
231+ border-color: #333333;
232+ border-width: 1px;
233+ background: white;
234+ position: absolute;
235+ top: -2px;
236+}
237+
238 QTabBar::tab {
239- height: 15px;
240- color: #333333;
241- background-color: #e4e0dd;
242+ background-color: #e3e0dd;
243 border-top-left-radius: 5px;
244 border-top-right-radius: 5px;
245+ border-bottom-right-radius: 1px;
246+ border-bottom-left-radius: 1px;
247 border-style: solid;
248 padding: 12px;
249- border-top-color: #939389;
250- border-right-color: #939389;
251- border-left-color: white;
252- border-bottom-color: #939389;
253+ border-color: #898989;
254+ border-left-color: #e3e0dd; /* same as background */
255 border-width: 1px;
256+ margin-bottom: 1px; /* to be able to override the QTabWidget border */
257+ border-bottom-color: #333333; /* same as background for QTabWidget */
258+}
259+
260+QTabBar::tab:first {
261+ border-left-color: #898989; /* same as border-color */
262+ border-bottom-left-radius: 0px;
263 }
264
265 QTabBar::tab:selected {
266 background-color: white;
267- border-top-left-radius: 5px;
268- border-top-right-radius: 5px;
269- border-style: solid;
270- padding: 12px;
271- border-top-color: #939389;
272- border-right-color: #939389;
273- border-left-color: white;
274- border-bottom-color: white;
275- border-width: 1px;
276-}
277-
278-QTabBar::tab:first {
279- border-left-color: #939389;
280-}
281-
282-QTabBar::tab:middle:!selected {
283- border-left-color: #e4e0dd;
284-}
285-
286-QTabBar::tab:last:!selected {
287- border-left-color: #e4e0dd;
288-}
289-
290-QTabBar::tab:hover {
291- background: #f6f6f6;
292- text-decoration: underline;
293-}
294-
295+ border-color: #333333;
296+ border-bottom-color: white; /* same as background for selected */
297+ border-bottom-right-radius: 0px;
298+ border-bottom-left-radius: 0px;
299+}
300+
301+QTabBar::tab:hover,
302 QTabBar::tab:focus {
303 text-decoration: underline;
304 /* hack to make the mild-orange focused box dissapear */
305@@ -266,24 +275,6 @@
306 /* end of hack */
307 }
308
309-QTabWidget {
310- border-bottom-left-radius: 5px;
311- border-bottom-right-radius: 5px;
312- border-style: solid;
313- padding: 10px;
314-}
315-
316-QTabWidget::pane {
317- border-bottom-left-radius: 5px;
318- border-bottom-right-radius: 5px;
319- border-top-right-radius: 5px;
320- border-style: solid;
321- border-color: #939389;
322- border-width: 1px;
323- background: white;
324- border-top: 2px solid white;
325-}
326-
327 QGroupBox {
328 padding-top: 30px;
329 border: none;
330@@ -332,10 +323,6 @@
331 margin-top: -4px;
332 }
333
334-QLabel#follow_us_label {
335- color: white;
336-}
337-
338 QLabel[OverQuota="true"],
339 QLabel#warning_label {
340 color: #df2d1f;
341@@ -343,7 +330,6 @@
342
343 QAbstractItemView {
344 border-style: solid;
345- border-color: #898989;
346 border-top-width: 1px;
347 border-bottom-width: 1px;
348 alternate-background-color: #f7f6f5;
349@@ -363,17 +349,6 @@
350 padding-right: 0px;
351 }
352
353-GoToWebButton#edit_profile_button,
354-GoToWebButton#edit_services_button,
355-GoToWebButton#get_more_space_button {
356- padding-left: 8px;
357- padding-right: 25px;
358- background-image: url(:/external_icon_white.png);
359- background-repeat: no-repeat;
360- background-position: right;
361- background-origin: margin;
362-}
363-
364 QSpinBox {
365 padding: 3px;
366 background-color: white;

Subscribers

People subscribed via source and target branches