Merge lp:~nataliabidart/ubuntuone-control-panel/messaging-menu into lp:ubuntuone-control-panel

Proposed by Natalia Bidart
Status: Merged
Approved by: Eric Casteleijn
Approved revision: 47
Merged at revision: 57
Proposed branch: lp:~nataliabidart/ubuntuone-control-panel/messaging-menu
Merge into: lp:ubuntuone-control-panel
Diff against target: 36 lines (+5/-2)
2 files modified
setup.py (+4/-2)
ubuntuone-control-panel.in (+1/-0)
To merge this branch: bzr merge lp:~nataliabidart/ubuntuone-control-panel/messaging-menu
Reviewer Review Type Date Requested Status
Eric Casteleijn (community) Approve
Roberto Alsina (community) Approve
Review via email: mp+47730@code.launchpad.net

Commit message

Added support to install u1cp-gtk in the messaging menu (LP: #708003).

Description of the change

We have U1CP in the messaging menu. No much testing instructions since all the magic happens when packaging this tiger.

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve
Revision history for this message
Eric Casteleijn (thisfred) wrote :

It werks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2011-01-25 18:51:17 +0000
3+++ setup.py 2011-01-27 21:10:01 +0000
4@@ -32,15 +32,16 @@
5
6 POT_FILE = 'po/ubuntuone-control-panel.pot'
7 SERVICE_FILE = 'com.ubuntuone.controlpanel.service'
8+MESSAGE_ENTRY = 'ubuntuone-control-panel'
9 CONSTANTS = 'ubuntuone/controlpanel/constants.py'
10
11-CLEANFILES = [SERVICE_FILE, CONSTANTS, POT_FILE, 'MANIFEST']
12+CLEANFILES = [SERVICE_FILE, MESSAGE_ENTRY, CONSTANTS, POT_FILE, 'MANIFEST']
13
14
15 def replace_prefix(prefix):
16 """Replace every '@prefix@' with prefix within 'filename' content."""
17 # replace .service file, DATA_DIR constant
18- for filename in (SERVICE_FILE, CONSTANTS):
19+ for filename in (SERVICE_FILE, MESSAGE_ENTRY, CONSTANTS):
20 with open(filename + '.in') as in_file:
21 content = in_file.read()
22 with open(filename, 'w') as out_file:
23@@ -88,6 +89,7 @@
24 ('lib/ubuntuone-control-panel',
25 ['bin/ubuntuone-control-panel-backend']),
26 ('share/dbus-1/services/', [SERVICE_FILE]),
27+ ('share/indicators/messages/applications/', [MESSAGE_ENTRY]),
28 ],
29 cmdclass={
30 'install': ControlPanelInstall,
31
32=== added file 'ubuntuone-control-panel.in'
33--- ubuntuone-control-panel.in 1970-01-01 00:00:00 +0000
34+++ ubuntuone-control-panel.in 2011-01-27 21:10:01 +0000
35@@ -0,0 +1,1 @@
36+@prefix@/share/applications/ubuntuone-control-panel-gtk.desktop

Subscribers

People subscribed via source and target branches