Merge lp:~nataliabidart/ubuntuone-control-panel/improve-volume-retrieval into lp:ubuntuone-control-panel
Status: | Merged |
---|---|
Approved by: | Natalia Bidart |
Approved revision: | 50 |
Merged at revision: | 49 |
Proposed branch: | lp:~nataliabidart/ubuntuone-control-panel/improve-volume-retrieval |
Merge into: | lp:ubuntuone-control-panel |
Diff against target: |
308 lines (+134/-46) 7 files modified
ubuntuone/controlpanel/backend.py (+10/-1) ubuntuone/controlpanel/dbus_client.py (+8/-0) ubuntuone/controlpanel/dbus_service.py (+15/-1) ubuntuone/controlpanel/integrationtests/test_dbus_client_sd.py (+28/-0) ubuntuone/controlpanel/integrationtests/test_dbus_service.py (+4/-20) ubuntuone/controlpanel/tests/__init__.py (+49/-23) ubuntuone/controlpanel/tests/test_backend.py (+20/-1) |
To merge this branch: | bzr merge lp:~nataliabidart/ubuntuone-control-panel/improve-volume-retrieval |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alejandro J. Cura (community) | Approve | ||
Roberto Alsina (community) | Approve | ||
Review via email: mp+46916@code.launchpad.net |
Commit message
- Backend provides a richer list of volumes, including the root info (LP: #705444).
Description of the change
The backend provides a richer volumes list info as per the new doc:
volumes_info
This is called by the gui to find out the volumes info for the current logged in user. The signals returned are:
* VolumesInfoReady with a list of volume information. Each volume is represented by a tuple with 3 fields: the volume owner (empty string for current user), the amount of free bytes in the volume, and a list of "volumes_dict". Each "volumes_dict" has (at least) the following values (depending on the type, there might be extra parameters):
o "volume_id" (unicode representation of an uuid)
o “path” (unicode)
o "suggested_path" (unicode)
o "subscribed" (boolean, same convention as before)
o "type" (unicode, either ROOT, UDF or SHARE)
* VolumesInfoError with the error
+1 but I only looked at the code.