Merge lp:~nataliabidart/ubuntuone-control-panel/fix-lint into lp:ubuntuone-control-panel

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 253
Merged at revision: 253
Proposed branch: lp:~nataliabidart/ubuntuone-control-panel/fix-lint
Merge into: lp:ubuntuone-control-panel
Diff against target: 120 lines (+19/-12)
6 files modified
ubuntuone/controlpanel/dbus_service.py (+5/-10)
ubuntuone/controlpanel/gui/gtk/gui.py (+2/-0)
ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py (+4/-0)
ubuntuone/controlpanel/gui/gtk/widgets.py (+3/-0)
ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py (+2/-2)
ubuntuone/controlpanel/tests/test_sd_client.py (+3/-0)
To merge this branch: bzr merge lp:~nataliabidart/ubuntuone-control-panel/fix-lint
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+89777@code.launchpad.net

Commit message

- Fix lint issues (LP: #920640).

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/controlpanel/dbus_service.py'
2--- ubuntuone/controlpanel/dbus_service.py 2011-09-14 19:08:52 +0000
3+++ ubuntuone/controlpanel/dbus_service.py 2012-01-23 20:19:25 +0000
4@@ -1,9 +1,6 @@
5 # -*- coding: utf-8 -*-
6-
7-# Authors: Alejandro J. Cura <alecu@canonical.com>
8-# Authors: Natalia B. Bidart <nataliabidart@canonical.com>
9 #
10-# Copyright 2010 Canonical Ltd.
11+# Copyright 2010-2012 Canonical Ltd.
12 #
13 # This program is free software: you can redistribute it and/or modify it
14 # under the terms of the GNU General Public License version 3, as published
15@@ -23,14 +20,12 @@
16 import sys
17
18 import dbus.service
19-# pylint: disable=E0611
20-# pylint: disable=W0404
21+# pylint: disable=E0611,W0404
22 if 'gobject' in sys.modules:
23 import gobject as GObject
24 else:
25 from gi.repository import GObject
26-# pylint: enable=W0404
27-# pylint: enable=E0611
28+# pylint: enable=E0611,W0404
29
30 from dbus.mainloop.glib import DBusGMainLoop
31 from dbus.service import method, signal
32@@ -156,6 +151,8 @@
33 class ControlPanelBackend(dbus.service.Object):
34 """Export the Control Panel backend thru DBus."""
35
36+ # pylint: disable=C0103,E1002
37+
38 def __init__(self, backend, *args, **kwargs):
39 """Create this instance of the backend."""
40 super(ControlPanelBackend, self).__init__(*args, **kwargs)
41@@ -164,8 +161,6 @@
42 logger.debug('ControlPanelBackend: created with %r, %r.',
43 args, kwargs)
44
45- # pylint: disable=C0103
46-
47 @log_call(logger.error)
48 @signal(dbus_interface=DBUS_PREFERENCES_IFACE, signature="a{ss}")
49 def UnauthorizedError(self, error):
50
51=== modified file 'ubuntuone/controlpanel/gui/gtk/gui.py'
52--- ubuntuone/controlpanel/gui/gtk/gui.py 2011-09-19 18:13:28 +0000
53+++ ubuntuone/controlpanel/gui/gtk/gui.py 2012-01-23 20:19:25 +0000
54@@ -840,6 +840,8 @@
55 else:
56 self.on_success()
57
58+ # Class 'style' has no 'bg' member
59+ # pylint: disable=E1101
60 odd_row_color = self.message.style.bg[gtk.STATE_NORMAL]
61 for i, device_info in enumerate(info):
62 device = Device(confirm_remove_dialog=self.confirm_remove_dialog)
63
64=== modified file 'ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py'
65--- ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py 2011-10-24 21:48:27 +0000
66+++ ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py 2012-01-23 20:19:25 +0000
67@@ -24,6 +24,10 @@
68 from ubuntuone.controlpanel.gui.gtk import widgets
69
70
71+# Class 'style' has no 'fg' member
72+# pylint: disable=E1101
73+
74+
75 class LoadingTestCase(TestCase):
76 """Test suite for the Loading widget (a spinner plus a label)."""
77
78
79=== modified file 'ubuntuone/controlpanel/gui/gtk/widgets.py'
80--- ubuntuone/controlpanel/gui/gtk/widgets.py 2011-04-11 17:30:04 +0000
81+++ ubuntuone/controlpanel/gui/gtk/widgets.py 2012-01-23 20:19:25 +0000
82@@ -130,6 +130,9 @@
83 # Invalid name, Missing docstring, do not list fix-mes
84 # pylint: disable=C0103,C0111,W0511
85
86+ # Class 'style' has no 'attach', 'set_background', 'paint_flat_box' member
87+ # pylint: disable=E1101
88+
89 __gsignals__ = {
90 "damage_event": "override",
91 }
92
93=== modified file 'ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py'
94--- ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py 2012-01-02 14:29:16 +0000
95+++ ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py 2012-01-23 20:19:25 +0000
96@@ -20,9 +20,9 @@
97 import sys
98
99 if sys.platform == "win32":
100- import windows as platform
101+ from ubuntuone.controlpanel.gui.qt.uniqueapp import windows as platform
102 else:
103- import linux as platform
104+ from ubuntuone.controlpanel.gui.qt.uniqueapp import linux as platform
105
106 #pylint: disable=C0103
107 UniqueApplication = platform.UniqueApplication
108
109=== modified file 'ubuntuone/controlpanel/tests/test_sd_client.py'
110--- ubuntuone/controlpanel/tests/test_sd_client.py 2011-11-21 13:32:44 +0000
111+++ ubuntuone/controlpanel/tests/test_sd_client.py 2012-01-23 20:19:25 +0000
112@@ -34,6 +34,9 @@
113 from ubuntuone.controlpanel import sd_client
114 from ubuntuone.controlpanel.tests import TestCase
115
116+# Instance of 'SyncDaemonTool' has no 'foo' member
117+# pylint: disable=E1101
118+
119
120 SAMPLE_LIMITS = {'upload': 999, 'download': 838}
121

Subscribers

People subscribed via source and target branches