Merge lp:~nataliabidart/ubuntuone-control-panel/devices into lp:ubuntuone-control-panel

[Natalia Bidart]

* Implemented devices tab (LP: #690649).

* Maximun size is set using geometry hints (LP: #683164).

To run the tests, do:

./run-tests

To test IRL, open 3 terminals pointing to this branch, and run:

terminal 1: DEBUG=True PYTHONPATH=. ./bin/ubuntuone-control-panel-backend
terminal 2: DEBUG=True PYTHONPATH=. ./bin/ubuntuone-control-panel-gtk

and play with the 3rd tab. Note: the 'Remove' device button so far does nothing. Throttling settings are properly updated, you can check by looking the ~/.config/ubuntuone/syncdaemon.conf file.

[Martin Albisetti (beuno)]

I am probably missing a lot of context, but when blindly trying to test this, I get:

beuno@beuno-laptop:~$ bzr branch lp:~nataliabidart/ubuntuone-control-panel/devices
Branched 44 revision(s).
beuno@beuno-laptop:~$ cd devices/
beuno@beuno-laptop:~/devices$ EBUG=True PYTHONPATH=. ./bin/ubuntuone-control-panel-backend
Traceback (most recent call last):
  File "./bin/ubuntuone-control-panel-backend", line 24, in <module>
    from ubuntuone.controlpanel import dbus_service
  File "/home/beuno/devices/ubuntuone/controlpanel/dbus_service.py", line 32, in <module>
    from ubuntuone.controlpanel.backend import (
  File "/home/beuno/devices/ubuntuone/controlpanel/backend.py", line 24, in <module>
    from ubuntuone.controlpanel import dbus_client
  File "/home/beuno/devices/ubuntuone/controlpanel/dbus_client.py", line 28, in <module>
    from ubuntuone.platform.linux import dbus_interface as sd_dbus_iface
ImportError: No module named platform.linux

[Roman Yepishev (rye)]

When an attempt is made to change max upload/download speed or enable/disable bandwidth usage limits some kind of flickering occurs which is not present in ubuntuone-preferences. It is pretty minor but it looks like it redraws the whole device entry after every change of widget values.

This can be seen here - http://ubuntuone.com/p/U8u/

review: Needs Fixing

[lp:~nataliabidart/ubuntuone-control-panel/devices]

45. By Natalia Bidart on 2010-12-17

Merged trunk in.

46. By Natalia Bidart on 2010-12-17

UI is not disabled while changing setting for a device.

[Roman Yepishev (rye)]

Yep, no flickering occurs.

review: Approve (fieldtest)

[Roberto Alsina (ralsina)]

Approved, fieldtested on narwhal.

review: Approve

=== added file 'data/device.ui'
--- data/device.ui	1970-01-01 00:00:00 +0000
+++ data/device.ui	2010-12-17 17:27:34 +0000
@@ -0,0 +1,201 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<interface>
+  <requires lib="gtk+" version="2.16"/>
+  <!-- interface-naming-policy project-wide -->
+  <object class="GtkVBox" id="itself">
+    <property name="visible">True</property>
+    <property name="spacing">5</property>
+    <child>
+      <object class="GtkHBox" id="hbox1">
+        <property name="visible">True</property>
+        <property name="spacing">15</property>
+        <child>
+          <object class="GtkVBox" id="vbox1">
+            <property name="visible">True</property>
+            <property name="spacing">5</property>
+            <child>
+              <object class="GtkHBox" id="hbox2">
+                <property name="visible">True</property>
+                <child>
+                  <object class="GtkImage" id="device_type">
+                    <property name="visible">True</property>
+                    <property name="icon_name">computer</property>
+                  </object>
+                  <packing>
+                    <property name="expand">False</property>
+                    <property name="position">0</property>
+                  </packing>
+                </child>
+                <child>
+                  <object class="GtkLabel" id="device_name">
+                    <property name="visible">True</property>
+                    <property name="xalign">0</property>
+                    <property name="xpad">5</property>
+                    <property name="label">My Laptop</property>
+                  </object>
+                  <packing>
+                    <property name="position">1</property>
+                  </packing>
+                </child>
+                <child>
+                  <object class="GtkLabel" id="device_id">
+                    <property name="label" translatable="yes">device id (hidden)</property>
+                  </object>
+                  <packing>
+                    <property name="expand">False</property>
+                    <property name="position">2</property>
+                  </packing>
+                </child>
+                <child>
+                  <object class="GtkLabel" id="date_added">
+                    <property name="label">30.02.09</property>
+                  </object>
+                  <packing>
+                    <property name="expand">False</property>
+                    <property name="position">3</property>
+                  </packing>
+                </child>
+              </object>
+              <packing>
+                <property name="position">0</property>
+              </packing>
+            </child>
+            <child>
+              <object class="GtkTable" id="throttling">
+                <property name="visible">True</property>
+                <property name="n_rows">3</property>
+                <property name="n_columns">2</property>
+                <property name="column_spacing">3</property>
+                <property name="row_spacing">3</property>
+                <child>
+                  <object class="GtkCheckButton" id="limit_bandwidth">
+                    <property name="label" translatable="yes">Limit bandwidth usage</property>
+                    <property name="visible">True</property>
+                    <property name="can_focus">True</property>
+                    <property name="receives_default">False</property>
+                    <property name="draw_indicator">True</property>
+                    <signal name="toggled" handler="on_limit_bandwidth_toggled"/>
+                  </object>
+                </child>
+                <child>
+                  <object class="GtkLabel" id="max_upload_speed_label">
+                    <property name="visible">True</property>
+                    <property name="xalign">1</property>
+                    <property name="xpad">5</property>
+                    <property name="label" translatable="yes">Max upload speed (KiB/s)</property>
+                  </object>
+                  <packing>
+                    <property name="top_attach">1</property>
+                    <property name="bottom_attach">2</property>
+                  </packing>
+                </child>
+                <child>
+                  <object class="GtkLabel" id="max_download_speed_label">
+                    <property name="visible">True</property>
+                    <property name="xalign">1</property>
+                    <property name="xpad">5</property>
+                    <property name="label" translatable="yes">Max download speed (KiB/s)</property>
+                  </object>
+                  <packing>
+                    <property name="top_attach">2</property>
+                    <property name="bottom_attach">3</property>
+                  </packing>
+                </child>
+                <child>
+                  <object class="GtkSpinButton" id="max_upload_speed">
+                    <property name="visible">True</property>
+                    <property name="can_focus">True</property>
+                    <property name="invisible_char">•</property>
+                    <property name="activates_default">True</property>
+                    <property name="adjustment">adjustment1</property>
+                    <signal name="value_changed" handler="on_max_upload_speed_value_changed"/>
+                  </object>
+                  <packing>
+                    <property name="left_attach">1</property>
+                    <property name="right_attach">2</property>
+                    <property name="top_attach">1</property>
+                    <property name="bottom_attach">2</property>
+                    <property name="x_options">GTK_FILL</property>
+                    <property name="y_options">GTK_FILL</property>
+                  </packing>
+                </child>
+                <child>
+                  <object class="GtkSpinButton" id="max_download_speed">
+                    <property name="visible">True</property>
+                    <property name="can_focus">True</property>
+                    <property name="invisible_char">•</property>
+                    <property name="activates_default">True</property>
+                    <property name="adjustment">adjustment2</property>
+                    <signal name="value_changed" handler="on_max_download_speed_value_changed"/>
+                  </object>
+                  <packing>
+                    <property name="left_attach">1</property>
+                    <property name="right_attach">2</property>
+                    <property name="top_attach">2</property>
+                    <property name="bottom_attach">3</property>
+                  </packing>
+                </child>
+                <child>
+                  <placeholder/>
+                </child>
+              </object>
+              <packing>
+                <property name="expand">False</property>
+                <property name="position">1</property>
+              </packing>
+            </child>
+          </object>
+          <packing>
+            <property name="expand">False</property>
+            <property name="position">0</property>
+          </packing>
+        </child>
+        <child>
+          <object class="GtkVButtonBox" id="vbuttonbox1">
+            <property name="visible">True</property>
+            <property name="layout_style">start</property>
+            <child>
+              <object class="GtkButton" id="remove">
+                <property name="label">gtk-remove</property>
+                <property name="visible">True</property>
+                <property name="can_focus">True</property>
+                <property name="receives_default">True</property>
+                <property name="use_stock">True</property>
+              </object>
+              <packing>
+                <property name="expand">False</property>
+                <property name="fill">False</property>
+                <property name="position">0</property>
+              </packing>
+            </child>
+          </object>
+          <packing>
+            <property name="expand">False</property>
+            <property name="pack_type">end</property>
+            <property name="position">1</property>
+          </packing>
+        </child>
+      </object>
+      <packing>
+        <property name="expand">False</property>
+        <property name="position">0</property>
+      </packing>
+    </child>
+    <child>
+      <object class="GtkLabel" id="warning_label">
+        <property name="visible">True</property>
+      </object>
+      <packing>
+        <property name="position">1</property>
+      </packing>
+    </child>
+  </object>
+  <object class="GtkAdjustment" id="adjustment1">
+    <property name="upper">10000</property>
+    <property name="step_increment">1</property>
+  </object>
+  <object class="GtkAdjustment" id="adjustment2">
+    <property name="upper">10000</property>
+    <property name="step_increment">1</property>
+  </object>
+</interface>

=== modified file 'data/devices.ui'
--- data/devices.ui	2010-10-21 21:14:24 +0000
+++ data/devices.ui	2010-12-17 17:27:34 +0000
@@ -7,7 +7,37 @@
     <property name="border_width">10</property>
     <property name="spacing">10</property>
     <child>
-      <placeholder/>
+      <object class="GtkScrolledWindow" id="scrolledwindow1">
+        <property name="visible">True</property>
+        <property name="can_focus">True</property>
+        <property name="hscrollbar_policy">automatic</property>
+        <property name="vscrollbar_policy">automatic</property>
+        <child>
+          <object class="GtkViewport" id="viewport1">
+            <property name="visible">True</property>
+            <property name="resize_mode">queue</property>
+            <property name="shadow_type">none</property>
+            <child>
+              <object class="GtkAlignment" id="alignment1">
+                <property name="visible">True</property>
+                <property name="xscale">0</property>
+                <property name="yscale">0</property>
+                <child>
+                  <object class="GtkVBox" id="devices">
+                    <property name="visible">True</property>
+                    <child>
+                      <placeholder/>
+                    </child>
+                  </object>
+                </child>
+              </object>
+            </child>
+          </object>
+        </child>
+      </object>
+      <packing>
+        <property name="position">0</property>
+      </packing>
     </child>
   </object>
 </interface>

=== modified file 'data/folders.ui'
--- data/folders.ui	2010-12-14 15:54:29 +0000
+++ data/folders.ui	2010-12-17 17:27:34 +0000
@@ -31,7 +31,7 @@
             <property name="resize_mode">queue</property>
             <property name="shadow_type">none</property>
             <child>
-              <object class="GtkAlignment" id="folders_alignment">
+              <object class="GtkAlignment" id="folders">
                 <property name="visible">True</property>
                 <property name="xscale">0</property>
                 <property name="yscale">0</property>

=== modified file 'ubuntuone/controlpanel/gtk/gui.py'
--- ubuntuone/controlpanel/gtk/gui.py	2010-12-14 19:16:25 +0000
+++ ubuntuone/controlpanel/gtk/gui.py	2010-12-17 17:27:34 +0000
@@ -47,6 +47,8 @@
 
 from ubuntuone.controlpanel import (DBUS_BUS_NAME, DBUS_PREFERENCES_PATH,
     DBUS_PREFERENCES_IFACE)
+from ubuntuone.controlpanel.backend import (DEVICE_TYPE_PHONE,
+    DEVICE_TYPE_COMPUTER)
 from ubuntuone.controlpanel.logger import setup_logging, log_call
 from ubuntuone.controlpanel.utils import get_data_file
 
@@ -69,6 +71,12 @@
     _('Sync data between computers.\n'
       '<small>«this is custom text #<i>N</i>»</small>')]
 WARNING_MARKUP = '<span foreground="%s"><b>%%s</b></span>' % ORANGE
+KILOBYTES = 1024
+
+
+def bool_str(value):
+    """Return the string representation of a bool (dbus-compatible)."""
+    return 'True' if value else ''
 
 
 def filter_by_app_name(f):
@@ -151,6 +159,8 @@
         self.set_title(self.TITLE % {'app_name': U1_APP_NAME})
         self.set_position(gtk.WIN_POS_CENTER_ALWAYS)
         self.set_icon_name('ubuntuone')
+        self.set_geometry_hints(max_width=736, max_height=525)  # bug #683164
+
         self.connect('delete-event', lambda w, e: gtk.main_quit())
         self.show()
 
@@ -377,7 +387,7 @@
     def __init__(self):
         UbuntuOneBin.__init__(self)
         ControlPanelMixin.__init__(self, filename='account.ui')
-        self.pack_start(self.itself)
+        self.add(self.itself)
         self.show()
 
         self.backend.connect_to_signal('AccountInfoReady',
@@ -421,7 +431,7 @@
     def __init__(self):
         UbuntuOneBin.__init__(self)
         ControlPanelMixin.__init__(self, filename='folders.ui')
-        self.pack_start(self.itself)
+        self.add(self.itself)
         self.show_all()
 
         self.backend.connect_to_signal('VolumesInfoReady',
@@ -433,13 +443,12 @@
         self.label_alignment.add(self.volumes_label)
         self._subscribed = []
 
-    @log_call(logger.debug)
     def on_volumes_info_ready(self, info):
         """Backend notifies of volumes info."""
         self.volumes_label.stop()
 
         if self.volumes is not None:
-            self.folders_alignment.remove(self.volumes)
+            self.folders.remove(self.volumes)
             self.volumes = None
 
         if not info:
@@ -473,7 +482,7 @@
             self._subscribed.append(subscribed)
             self.volumes.attach(subscribed, 1, 2, i + 1, i + 2, xoptions=0)
 
-        self.folders_alignment.add(self.volumes)
+        self.folders.add(self.volumes)
 
     @log_call(logger.error)
     def on_volumes_info_error(self, error_dict=None):
@@ -485,7 +494,7 @@
     def on_subscribed_clicked(self, checkbutton):
         """The user toggled 'checkbutton'."""
         volume_id = checkbutton.get_label()
-        subscribed = 'True' if checkbutton.get_active() else ''
+        subscribed = bool_str(checkbutton.get_active())
         self.backend.change_volume_settings(volume_id,
                                             {'subscribed': subscribed})
 
@@ -495,6 +504,140 @@
         self.volumes_label.start()
 
 
+class Device(gtk.VBox, ControlPanelMixin):
+    """The devices panel."""
+
+    DEVICE_CHANGE_ERROR = _('The settings could not be changed,\n'
+                            'previous values were restored.')
+
+    def __init__(self):
+        gtk.VBox.__init__(self)
+        ControlPanelMixin.__init__(self, filename='device.ui')
+
+        self._updating = False
+        self._last_settings = {}
+        self.configurable = False
+
+        self.update(device_id='', device_name='', limit_bandwidth=False,
+                    max_upload_speed=0, max_download_speed=0)
+
+        self.add(self.itself)
+        self.device_id.hide()
+        self.show()
+
+        self.backend.connect_to_signal('DeviceSettingsChanged',
+                                       self.on_device_settings_changed)
+        self.backend.connect_to_signal('DeviceSettingsChangeError',
+                                       self.on_device_settings_change_error)
+
+    def _change_device_settings(self, *args):
+        """Update backend settings for this device."""
+        if self._updating:
+            return
+
+        # Not disabling the GUI to avoid annyong twitchings
+        #self.set_sensitive(False)
+        self.warning_label.set_text('')
+        self.backend.change_device_settings(self.device_id.get_text(),
+                                            self.__dict__)
+
+    def _block_signals(f):
+        """Execute 'f' while having the _updating flag set."""
+
+        # pylint: disable=E0213,W0212,E1102
+
+        @wraps(f)
+        def inner(self, *args, **kwargs):
+            """Execute 'f' while having the _updating flag set."""
+            old = self._updating
+            self._updating = True
+
+            result = f(self, *args, **kwargs)
+
+            self._updating = old
+            return result
+
+        return inner
+
+    on_limit_bandwidth_toggled = _change_device_settings
+    on_max_upload_speed_value_changed = _change_device_settings
+    on_max_download_speed_value_changed = _change_device_settings
+
+    @_block_signals
+    def update(self, **kwargs):
+        """Update according to named parameters.
+
+        Possible settings are:
+            * device_id (string, not shown to the user)
+            * device_name (string)
+            * type (either DEVICE_TYPE_PHONE or DEVICE_TYPE_COMPUTER)
+            * configurable (True/False)
+            * if configurable, the following can be set:
+                * limit_bandwidth (True/False)
+                * max_upload_speed (bytes)
+                * max_download_speed (bytes)
+
+        """
+        if 'device_id' in kwargs:
+            self.device_id.set_text(kwargs['device_id'])
+
+        if 'device_name' in kwargs:
+            self.device_name.set_markup('<b>%s</b>' % kwargs['device_name'])
+
+        if 'device_type' in kwargs:
+            dtype = kwargs['device_type']
+            if dtype in (DEVICE_TYPE_COMPUTER, DEVICE_TYPE_PHONE):
+                self.device_type.set_from_icon_name(dtype.lower(),
+                                                    gtk.ICON_SIZE_BUTTON)
+
+        if 'configurable' in kwargs:
+            self.configurable = bool(kwargs['configurable'])
+            self.throttling.set_visible(self.configurable)
+
+        if 'limit_bandwidth' in kwargs:
+            self.limit_bandwidth.set_active(bool(kwargs['limit_bandwidth']))
+
+        for speed in ('max_upload_speed', 'max_download_speed'):
+            if speed in kwargs:
+                value = int(kwargs[speed]) // KILOBYTES
+                getattr(self, speed).set_value(value)
+
+        self._last_settings = self.__dict__
+
+    @property
+    def __dict__(self):
+        result = {
+            'device_id': self.device_id.get_text(),
+            'device_name': self.device_name.get_text(),
+            'device_type': self.device_type.get_icon_name()[0].capitalize(),
+            'configurable': bool_str(self.configurable),
+            'limit_bandwidth': bool_str(self.limit_bandwidth.get_active()),
+            'max_upload_speed': \
+                str(self.max_upload_speed.get_value_as_int() * KILOBYTES),
+            'max_download_speed': \
+                str(self.max_download_speed.get_value_as_int() * KILOBYTES),
+        }
+        return result
+
+    @log_call(logger.info)
+    def on_device_settings_changed(self, device_id):
+        """The change of this device settings succeded."""
+        if device_id != self.device_id.get_text():
+            return
+        self.set_sensitive(True)
+        self.warning_label.set_text('')
+        self._last_settings = self.__dict__
+
+    @log_call(logger.error)
+    def on_device_settings_change_error(self, device_id, error_dict=None):
+        """The change of this device settings failed."""
+        if device_id != self.device_id.get_text():
+            return
+        self.update(**self._last_settings)
+        self._set_warning(self.DEVICE_CHANGE_ERROR, self.warning_label)
+        self.set_sensitive(True)
+
+
 class DevicesPanel(UbuntuOneBin, ControlPanelMixin):
     """The devices panel."""
 
@@ -504,9 +647,29 @@
     def __init__(self):
         UbuntuOneBin.__init__(self)
         ControlPanelMixin.__init__(self, filename='devices.ui')
-        self.pack_start(self.itself)
+        self.add(self.itself)
         self.show()
 
+        self.backend.connect_to_signal('DevicesInfoReady',
+                                       self.on_devices_info_ready)
+        self.backend.connect_to_signal('DevicesInfoError',
+                                       self.on_devices_info_error)
+        self.backend.devices_info()
+
+    def on_devices_info_ready(self, info):
+        """Backend notifies of devices info."""
+        for device_info in info:
+            device = Device()
+            device_info['device_name'] = device_info.pop('name', '')
+            device_info['device_type'] = device_info.pop('type',
+                                                         DEVICE_TYPE_COMPUTER)
+            device.update(**device_info)
+            self.devices.pack_start(device)
+
+    @log_call(logger.error)
+    def on_devices_info_error(self, error_dict=None):
+        """Backend notifies of an error when fetching volumes info."""
+
 
 class ApplicationsPanel(UbuntuOneBin, ControlPanelMixin):
     """The applications panel."""
@@ -517,7 +680,7 @@
     def __init__(self):
         UbuntuOneBin.__init__(self)
         ControlPanelMixin.__init__(self, filename='applications.ui')
-        self.pack_start(self.itself)
+        self.add(self.itself)
         self.show()
 
 
@@ -543,7 +706,7 @@
     def __init__(self):
         gtk.VBox.__init__(self)
         ControlPanelMixin.__init__(self, filename='management.ui')
-        self.pack_start(self.itself)
+        self.add(self.itself)
         self.show()
 
         self.backend.connect_to_signal('AccountInfoReady',

=== modified file 'ubuntuone/controlpanel/gtk/tests/test_gui.py'
--- ubuntuone/controlpanel/gtk/tests/test_gui.py	2010-12-14 19:16:25 +0000
+++ ubuntuone/controlpanel/gtk/tests/test_gui.py	2010-12-17 17:27:34 +0000
@@ -45,6 +45,23 @@
     {'volume_id': '2', 'suggested_path': '~/baz', 'subscribed': 'True'},
 ]
 
+FAKE_DEVICE_INFO = {
+    'device_id': '1258-6854', 'device_name': 'Baz', 'device_type': 'Computer',
+    'configurable': 'True', 'limit_bandwidth': 'True',
+    'max_upload_speed': '1000', 'max_download_speed': '72548',
+}
+
+FAKE_DEVICES_INFO = [
+    {'device_id': '0', 'name': 'Foo', 'type': 'Computer', 'configurable': ''},
+    {'device_id': '1', 'name': 'Bar', 'type': 'Phone', 'configurable': ''},
+    {'device_id': '2', 'name': 'Z', 'type': 'Computer',
+     'configurable': 'True', 'limit_bandwidth': '',
+     'max_upload_speed': '0', 'max_download_speed': '0'},
+    {'device_id': '1258-6854', 'name': 'Baz', 'type': 'Computer',
+     'configurable': 'True', 'limit_bandwidth': 'True',
+     'max_upload_speed': '1000', 'max_download_speed': '72548'},
+]
+
 
 class FakedObject(object):
     """Fake an object, record every call."""
@@ -108,8 +125,10 @@
     bus_name = gui.DBUS_BUS_NAME
     object_path = gui.DBUS_PREFERENCES_PATH
     iface = gui.DBUS_PREFERENCES_IFACE
-    exposed_methods = ['account_info', 'devices_info', 'volumes_info',
-                       'file_sync_status', 'change_volume_settings']
+    exposed_methods = [
+        'account_info', 'devices_info', 'change_device_settings',
+        'volumes_info', 'change_volume_settings', 'file_sync_status',
+    ]
 
 
 class FakedSessionBus(object):
@@ -268,8 +287,8 @@
         self.assertEqual(self.ui.get_icon_name(), 'ubuntuone')
 
     def test_max_size(self):
-        """Max size is not bigger than 966x576 (LP: #645526)."""
-        self.assertTrue(self.ui.get_size_request() <= (966, 576))
+        """Max size is not bigger than 736x525 (LP: #645526, LP: #683164)."""
+        self.assertTrue(self.ui.get_size_request() <= (736, 525))
 
 
 class ControlPanelTestCase(ControlPanelMixinTestCase):
@@ -801,8 +820,7 @@
         self.ui.on_volumes_info_ready(FAKE_VOLUMES_INFO)
 
         self.assertFalse(self.ui.label_alignment.get_visible())
-        self.assertEqual(self.ui.folders_alignment.get_children(),
-                         [self.ui.volumes])
+        self.assertEqual(self.ui.folders.get_children(), [self.ui.volumes])
 
         volumes = self.ui.volumes.get_children()
         volumes.reverse()
@@ -828,8 +846,8 @@
         self.ui.on_volumes_info_ready(FAKE_VOLUMES_INFO)
         self.ui.on_volumes_info_ready(FAKE_VOLUMES_INFO)
 
-        self.assertEqual(len(self.ui.folders_alignment.get_children()), 1)
-        child = self.ui.folders_alignment.get_children()[0]
+        self.assertEqual(len(self.ui.folders.get_children()), 1)
+        child = self.ui.folders.get_children()[0]
         self.assertEqual(child, self.ui.volumes)
 
         volumes = filter(lambda w: isinstance(w, gui.gtk.CheckButton),
@@ -840,7 +858,7 @@
         """When there are no volumes, a notification is shown."""
         self.ui.on_volumes_info_ready([])
         # no volumes table
-        self.assertEqual(len(self.ui.folders_alignment.get_children()), 0)
+        self.assertEqual(len(self.ui.folders.get_children()), 0)
         self.assertTrue(self.ui.volumes is None)
 
     def test_on_subscribed_clicked(self):
@@ -852,14 +870,14 @@
             checkbutton.clicked()
             fid = checkbutton.get_label()
 
-            subscribed = 'True' if checkbutton.get_active() else ''
+            subscribed = gui.bool_str(checkbutton.get_active())
             self.assert_backend_called(method,
                                        (fid, {'subscribed': subscribed}))
             # clean backend calls
             self.ui.backend._called.pop(method)
 
             checkbutton.clicked()
-            subscribed = 'True' if checkbutton.get_active() else ''
+            subscribed = gui.bool_str(checkbutton.get_active())
             self.assert_backend_called('change_volume_settings',
                                        (fid, {'subscribed': subscribed}))
 
@@ -881,6 +899,239 @@
         self.test_on_volumes_info_ready_with_no_volumes()
 
 
+class DeviceTestCase(ControlPanelMixinTestCase):
+    """The test suite for the device widget."""
+
+    klass = gui.Device
+    ui_filename = 'device.ui'
+
+    def assert_device_equal(self, device, expected):
+        """Assert that the device has the values from expected."""
+        self.assertEqual(device.device_id.get_text(),
+                         expected['device_id'])
+        self.assertEqual(device.device_name.get_text(),
+                         expected['device_name'])
+        self.assertEqual(device.device_type.get_icon_name()[0],
+                         expected['device_type'].lower())
+        self.assertEqual(device.configurable,
+                         bool(expected['configurable']))
+        self.assertEqual(device.limit_bandwidth.get_active(),
+                         bool(expected['limit_bandwidth']))
+
+        value = int(expected['max_upload_speed']) // gui.KILOBYTES
+        self.assertEqual(device.max_upload_speed.get_value_as_int(), value)
+        value = int(expected['max_download_speed']) // gui.KILOBYTES
+        self.assertEqual(device.max_download_speed.get_value_as_int(), value)
+
+    def assert_device_settings_changed(self):
+        """Changing throttling settings updates the backend properly."""
+        expected = self.ui.__dict__
+        self.assert_backend_called('change_device_settings',
+                                   (self.ui.device_id.get_text(), expected))
+        self.assertEqual(self.ui.warning_label.get_text(), '')
+
+    def modify_settings(self):
+        """Modify settings so values actually change."""
+        new_val = not self.ui.limit_bandwidth.get_active()
+        self.ui.limit_bandwidth.set_active(new_val)
+
+        new_val = self.ui.max_upload_speed.get_value_as_int() + 1
+        self.ui.max_upload_speed.set_value(new_val)
+
+        new_val = self.ui.max_download_speed.get_value_as_int() + 1
+        self.ui.max_download_speed.set_value(new_val)
+
+    def test_is_a_vbox(self):
+        """Inherits from VBox."""
+        self.assertIsInstance(self.ui, gui.gtk.VBox)
+
+    def test_inner_widget_is_packed(self):
+        """The 'itself' vbox is packed into the widget."""
+        self.assertIn(self.ui.itself, self.ui.get_children())
+
+    def test_is_visible(self):
+        """Is visible."""
+        self.assertTrue(self.ui.get_visible())
+
+    def test_is_sensitive(self):
+        """Is sensitive."""
+        self.assertTrue(self.ui.get_sensitive())
+
+    def test_warning_label_is_cleared(self):
+        """The warning label is cleared."""
+        self.assertEqual(self.ui.warning_label.get_text(), '')
+
+    def test_device_id_is_hidden(self):
+        """The device id label is hidden."""
+        self.assertFalse(self.ui.device_id.get_visible())
+
+    def test_default_values(self):
+        """Default values are correct."""
+        self.assertEqual(self.ui.device_id.get_text(), '')
+        self.assertEqual(self.ui.device_name.get_text(), '')
+        self.assertEqual(self.ui.device_type.get_icon_name()[0],
+                         gui.DEVICE_TYPE_COMPUTER.lower())
+        self.assertEqual(self.ui.configurable, False)
+        self.assertEqual(self.ui.limit_bandwidth.get_active(), False)
+        self.assertEqual(self.ui.max_upload_speed.get_value_as_int(), 0)
+        self.assertEqual(self.ui.max_download_speed.get_value_as_int(), 0)
+
+    def test_init_does_not_call_backend(self):
+        """When updating, the backend is not called."""
+        self.assertEqual(self.ui.backend._called, {})
+
+    def test_update_device_id(self):
+        """A device can be updated from a dict."""
+        value = '741-822-963'
+        self.ui.update(device_id=value)
+        self.assertEqual(value, self.ui.device_id.get_text())
+
+    def test_update_device_name(self):
+        """A device can be updated from a dict."""
+        value = 'The death star'
+        self.ui.update(device_name=value)
+        self.assertEqual(value, self.ui.device_name.get_text())
+
+    def test_update_unicode_device_name(self):
+        """A device can be updated from a dict."""
+        value = u'Ñoño Ñandú'
+        self.ui.update(device_name=value)
+        self.assertEqual(value, self.ui.device_name.get_text())
+
+    def test_update_device_type_computer(self):
+        """A device can be updated from a dict."""
+        dtype = gui.DEVICE_TYPE_COMPUTER
+        self.ui.update(device_type=dtype)
+        self.assertEqual((dtype.lower(), gui.gtk.ICON_SIZE_BUTTON),
+                         self.ui.device_type.get_icon_name())
+
+    def test_update_device_type_phone(self):
+        """A device can be updated from a dict."""
+        dtype = gui.DEVICE_TYPE_PHONE
+        self.ui.update(device_type=dtype)
+        self.assertEqual((dtype.lower(), gui.gtk.ICON_SIZE_BUTTON),
+                         self.ui.device_type.get_icon_name())
+
+    def test_update_configurable(self):
+        """A device can be updated from a dict."""
+        self.ui.update(configurable='')
+        self.assertFalse(self.ui.configurable)
+        self.assertFalse(self.ui.throttling.get_visible())
+
+    def test_update_non_configurable(self):
+        """A device can be updated from a dict."""
+        self.ui.update(configurable='True')
+        self.assertTrue(self.ui.configurable)
+        self.assertTrue(self.ui.throttling.get_visible())
+
+    def test_update_limit_bandwidth(self):
+        """A device can be updated from a dict."""
+        self.ui.update(limit_bandwidth='')
+        self.assertFalse(self.ui.limit_bandwidth.get_active())
+
+        self.ui.update(limit_bandwidth='True')
+        self.assertTrue(self.ui.limit_bandwidth.get_active())
+
+    def test_update_upload_speed(self):
+        """A device can be updated from a dict."""
+        value = '12345'
+        self.ui.update(max_upload_speed=value)
+        self.assertEqual(int(value) // gui.KILOBYTES,
+                         self.ui.max_upload_speed.get_value_as_int())
+
+    def test_update_download_speed(self):
+        """A device can be updated from a dict."""
+        value = '987654'
+        self.ui.update(max_download_speed=value)
+        self.assertEqual(int(value) // gui.KILOBYTES,
+                         self.ui.max_download_speed.get_value_as_int())
+
+    def test_update_does_not_call_backend(self):
+        """When updating, the backend is not called."""
+        self.ui.update(**FAKE_DEVICE_INFO)
+        self.assertEqual(self.ui.backend._called, {})
+        self.assert_device_equal(self.ui, FAKE_DEVICE_INFO)
+
+    def test_on_limit_bandwidth_toggled(self):
+        """When toggling limit_bandwidth, backend is updated."""
+        self.ui.limit_bandwidth.toggled()
+        self.assert_device_settings_changed()
+
+    def test_on_max_upload_speed_value_changed(self):
+        """When setting max_upload_speed, backend is updated."""
+        self.ui.max_upload_speed.set_value(25)
+        self.assert_device_settings_changed()
+
+    def test_on_max_download_speed_value_changed(self):
+        """When setting max_download_speed, backend is updated."""
+        self.ui.max_download_speed.set_value(52)
+        self.assert_device_settings_changed()
+
+    def test_backend_signals(self):
+        """The proper signals are connected to the backend."""
+        self.assertEqual(self.ui.backend._signals['DeviceSettingsChanged'],
+                         [self.ui.on_device_settings_changed])
+        self.assertEqual(self.ui.backend._signals['DeviceSettingsChangeError'],
+                         [self.ui.on_device_settings_change_error])
+
+    def test_on_device_settings_changed(self):
+        """When settings were changed for this device, enable it."""
+        self.modify_settings()
+        did = self.ui.device_id.get_text()
+        self.ui.on_device_settings_changed(device_id=did)
+
+        self.assertTrue(self.ui.get_sensitive())
+        self.assertEqual(self.ui.warning_label.get_text(), '')
+        self.assertEqual(self.ui.__dict__, self.ui._last_settings)
+
+    def test_on_device_settings_change_after_error(self):
+        """Change success after error."""
+        self.modify_settings()
+        did = self.ui.device_id.get_text()
+        self.ui.on_device_settings_change_error(device_id=did)  # change failed
+
+        self.test_on_device_settings_changed()
+
+    def test_on_device_settings_changed_different_id(self):
+        """When settings were changed for other device, nothing changes."""
+        self.modify_settings()
+        self.ui.on_device_settings_changed(device_id='yadda')
+
+        self.assertEqual(self.ui.warning_label.get_text(), '')
+
+    def test_on_device_settings_change_error(self):
+        """When settings were not changed for this device, notify the user.
+
+        Also, confirm that old values were restored.
+
+        """
+        self.ui.update(**FAKE_DEVICE_INFO)  # use known values
+
+        self.modify_settings()
+
+        did = self.ui.device_id.get_text()
+        self.ui.on_device_settings_change_error(device_id=did)  # change failed
+
+        self.assertTrue(self.ui.get_sensitive())
+        self.assert_warning_correct(self.ui.warning_label,
+                                    self.ui.DEVICE_CHANGE_ERROR)
+        self.assert_device_equal(self.ui, FAKE_DEVICE_INFO)  # restored info
+
+    def test_on_device_settings_change_error_after_success(self):
+        """Change error after success."""
+        self.modify_settings()
+        did = self.ui.device_id.get_text()
+        self.ui.on_device_settings_changed(device_id=did)
+
+        self.test_on_device_settings_change_error()
+
+    def test_on_device_settings_change_error_different_id(self):
+        """When settings were not changed for other device, do nothing."""
+        self.modify_settings()
+        self.ui.on_device_settings_change_error(device_id='yudo')
+        self.assertEqual(self.ui.warning_label.get_text(), '')
+
+
 class DevicesTestCase(ControlPanelMixinTestCase):
     """The test suite for the devices panel."""
 
@@ -899,6 +1150,50 @@
         """Is visible."""
         self.assertTrue(self.ui.get_visible())
 
+    def test_backend_signals(self):
+        """The proper signals are connected to the backend."""
+        self.assertEqual(self.ui.backend._signals['DevicesInfoReady'],
+                         [self.ui.on_devices_info_ready])
+        self.assertEqual(self.ui.backend._signals['DevicesInfoError'],
+                         [self.ui.on_devices_info_error])
+
+    def test_devices_info_is_requested(self):
+        """The devices info is requested to the backend."""
+        self.assert_backend_called('devices_info', ())
+
+    def test_on_devices_info_ready(self):
+        """The devices info is processed when ready."""
+        self.ui.on_devices_info_ready(FAKE_DEVICES_INFO)
+
+        children = self.ui.devices.get_children()
+        self.assertEqual(len(children), len(FAKE_DEVICES_INFO))
+
+        for child, device in zip(children, FAKE_DEVICES_INFO):
+            self.assertIsInstance(child, gui.Device)
+
+            self.assertEqual(device['device_id'],
+                             child.device_id.get_text())
+            self.assertEqual(device['device_name'],
+                             child.device_name.get_text())
+            self.assertEqual(device['device_type'].lower(),
+                             child.device_type.get_icon_name()[0])
+            self.assertEqual(bool(device['configurable']),
+                             child.configurable)
+
+            if bool(device['configurable']):
+                self.assertEqual(bool(device['limit_bandwidth']),
+                                 child.limit_bandwidth.get_active())
+                value = int(device['max_upload_speed']) // gui.KILOBYTES
+                self.assertEqual(value,
+                                 child.max_upload_speed.get_value_as_int())
+                value = int(device['max_download_speed']) // gui.KILOBYTES
+                self.assertEqual(value,
+                                 child.max_download_speed.get_value_as_int())
+
+    def test_on_devices_info_error(self):
+        """The devices info couldn't be retrieved."""
+        self.ui.on_devices_info_error()
+
 
 class ApplicationsTestCase(ControlPanelMixinTestCase):
     """The test suite for the applications panel."""