Merge lp:~nataliabidart/ubuntuone-control-panel/delay-reload-folders into lp:ubuntuone-control-panel

Proposed by Natalia Bidart
Status: Merged
Approved by: Roberto Alsina
Approved revision: 220
Merged at revision: 220
Proposed branch: lp:~nataliabidart/ubuntuone-control-panel/delay-reload-folders
Merge into: lp:ubuntuone-control-panel
Diff against target: 29 lines (+10/-2)
1 file modified
ubuntuone/controlpanel/gui/qt/folders.py (+10/-2)
To merge this branch: bzr merge lp:~nataliabidart/ubuntuone-control-panel/delay-reload-folders
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+74633@code.launchpad.net

Commit message

- Dirty fix for having the folder list properly reloading after a folder creation (LP: #839907).

To post a comment you must log in.
220. By Natalia Bidart

Increasing call late to 2 seconds to try to match slow machines.

Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/controlpanel/gui/qt/folders.py'
2--- ubuntuone/controlpanel/gui/qt/folders.py 2011-09-08 17:32:40 +0000
3+++ ubuntuone/controlpanel/gui/qt/folders.py 2011-09-08 21:31:24 +0000
4@@ -69,8 +69,7 @@
5 def _setup(self):
6 """Do some extra setupping for the UI."""
7 super(FoldersPanel, self)._setup()
8- load_info = lambda *a, **kw: self.load()
9- self.ui.add_folder_button.folderCreated.connect(load_info)
10+ self.ui.add_folder_button.folderCreated.connect(self.on_folder_created)
11
12 headers = self.ui.folders.header()
13 headers.setResizeMode(FOLDER_NAME_COL, headers.Stretch)
14@@ -82,6 +81,15 @@
15 icon = icon_from_name('external_icon_orange')
16 self.ui.share_publish_button.setIcon(icon)
17
18+ @log_call(logger.info)
19+ def on_folder_created(self, new_folder):
20+ """Reload folder info after folder creation."""
21+ self.is_processing = True
22+ # hack to ensure that syncdaemon updates the folder list.
23+ # pylint: disable=W0404, E1101
24+ from twisted.internet import reactor
25+ reactor.callLater(2, self.load)
26+
27 # pylint: disable=E0202
28 @defer.inlineCallbacks
29 def load(self):

Subscribers

People subscribed via source and target branches