Code review comment for lp:~nataliabidart/ubuntuone-control-panel/default-folders

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

> 94 + with open(dirs_path) as f:
> 95 + while True:
> 96 + line = f.readline()
>
> The file object you get back (f) is already iterable, so you could replace the
> "while True" with "for line in f"
>
> Other than this it looks alright.

Fixed and pushed, great catch! thanks

« Back to merge proposal