Code review comment for lp:~nataliabidart/ubuntuone-control-panel/default-folders

Revision history for this message
Brian Curtin (brian.curtin) wrote :

94 + with open(dirs_path) as f:
95 + while True:
96 + line = f.readline()

The file object you get back (f) is already iterable, so you could replace the "while True" with "for line in f"

Other than this it looks alright.

review: Needs Fixing

« Back to merge proposal