Code review comment for lp:~nataliabidart/ubuntuone-control-panel/computer-to-cloud-page

Revision history for this message
Eric Casteleijn (thisfred) wrote :

It all works as expected!

Code looks good, but it does use new style and old style formatting: The problem is that while new style formatting has an awesome syntax, it is reportedly much slower than the old style, *and* it may tie us to a newer Python than we want without good reason.

Old style formatting is not scheduled to ever disappear from the language so I feel we should stick with that, at least until the performance problems are solved, and everyone is on a python that supports it, but maybe just forever.

review: Approve

« Back to merge proposal