Code review comment for lp:~nataliabidart/ubuntuone-client/split-oauth

Revision history for this message
dobey (dobey) wrote :

The tests/test_login.py needs to be moved to the ubuntu-sso-client tree, rather than staying here. Ideally the oauthdesktop code should be fixed to not use twisted for the temporary local http server any more. And in fact, it won't need to have a local server after it is fixed to not use the browser for doing auth. Moving this test will also obviate the need for having the symlink to ubuntu-login.

We're also going to need to have the symlink creation either be automated (or unneccessary).

Given the hour though, we can discuss it more tomorrow.

review: Needs Fixing

« Back to merge proposal