Merge lp:~nataliabidart/ubuntuone-client/login-not-register into lp:ubuntuone-client

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 1199
Merged at revision: 1199
Proposed branch: lp:~nataliabidart/ubuntuone-client/login-not-register
Merge into: lp:ubuntuone-client
Diff against target: 40 lines (+5/-5)
2 files modified
tests/syncdaemon/test_interaction_interfaces.py (+4/-4)
ubuntuone/syncdaemon/interaction_interfaces.py (+1/-1)
To merge this branch: bzr merge lp:~nataliabidart/ubuntuone-client/login-not-register
Reviewer Review Type Date Requested Status
Roberto Alsina (community) Approve
Review via email: mp+95440@code.launchpad.net

Commit message

- Call CredentialsManagementTool.login when prompt to connect (LP: #944230).

To post a comment you must log in.
Revision history for this message
Roberto Alsina (ralsina) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/syncdaemon/test_interaction_interfaces.py'
2--- tests/syncdaemon/test_interaction_interfaces.py 2012-02-18 16:13:04 +0000
3+++ tests/syncdaemon/test_interaction_interfaces.py 2012-03-01 19:29:03 +0000
4@@ -84,11 +84,11 @@
5 self._kwargs = kwargs
6 self._called = {}
7
8- def register(self, *args, **kwargs):
9- """Fake register."""
10+ def login(self, *args, **kwargs):
11+ """Fake login."""
12 if self.should_fail:
13 return defer.fail(self.should_fail)
14- self._called['register'] = (args, kwargs)
15+ self._called['login'] = (args, kwargs)
16 return defer.succeed(self.credentials)
17
18 def find_credentials(self, *args, **kwargs):
19@@ -2291,7 +2291,7 @@
20 """
21
22 sd_class = SyncdaemonService
23- method = 'register'
24+ method = 'login'
25 autoconnecting = False
26
27 @defer.inlineCallbacks
28
29=== modified file 'ubuntuone/syncdaemon/interaction_interfaces.py'
30--- ubuntuone/syncdaemon/interaction_interfaces.py 2012-02-18 16:13:04 +0000
31+++ ubuntuone/syncdaemon/interaction_interfaces.py 2012-03-01 19:29:03 +0000
32@@ -1245,7 +1245,7 @@
33 if autoconnecting:
34 return management.find_credentials()
35 else:
36- return management.register(window_id=0) # no window ID
37+ return management.login(window_id=0) # no window ID
38
39 @log_call(logger.debug)
40 def disconnect(self):

Subscribers

People subscribed via source and target branches