Merge lp:~nataliabidart/ubuntuone-client/fix-create_share_http into lp:ubuntuone-client

Proposed by Natalia Bidart on 2009-12-03
Status: Merged
Approved by: John O'Brien on 2009-12-07
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~nataliabidart/ubuntuone-client/fix-create_share_http
Merge into: lp:ubuntuone-client
Diff against target: 12 lines (+1/-1)
1 file modified
ubuntuone/syncdaemon/action_queue.py (+1/-1)
To merge this branch: bzr merge lp:~nataliabidart/ubuntuone-client/fix-create_share_http
Reviewer Review Type Date Requested Status
John O'Brien (community) Approve on 2009-12-07
Stuart Langridge (community) Abstain on 2009-12-07
Facundo Batista 2009-12-03 Approve on 2009-12-03
Review via email: mp+15622@code.launchpad.net

Commit message

Fixing bug introduced on revno 220: callback() takes exactly 2 arguments (1 given).

To post a comment you must log in.
Natalia Bidart (nataliabidart) wrote :

Fixing bug introduced on revno 220.

dobey (dobey) wrote :

Is there not a bug report for this? We'll need one, as this presumably affects stable-1-0 also, and we'll need to get it in an SRU.

Facundo Batista (facundo) wrote :

Like it!

review: Approve
Stuart Langridge (sil) wrote :

I don't know what this is fixing :(

review: Abstain
Natalia Bidart (nataliabidart) wrote :

> I don't know what this is fixing :(

The error is the one specified on the commit message:

"callback() takes exactly 2 arguments (1 given)"

If no argument is passed to deferred.callback, it fails and the share can not be made.

John O'Brien (jdobrien) wrote :

good catch

review: Approve
Natalia Bidart (nataliabidart) wrote :

> Is there not a bug report for this? We'll need one, as this presumably affects
> stable-1-0 also, and we'll need to get it in an SRU.

Yes, indeed. I created Bug #494024 with tag ubuntuone-sru.

Thanks for the reminder!

dobey (dobey) wrote :

On Tue, 2009-12-08 at 13:38 +0000, Naty Bidart wrote:
> > Is there not a bug report for this? We'll need one, as this presumably affects
> > stable-1-0 also, and we'll need to get it in an SRU.
>
> Yes, indeed. I created Bug #494024 with tag ubuntuone-sru.
>
> Thanks for the reminder!

I've updated this accordingly as it looks like Roman (rtgv) had already
filed this as bug #492100 on the same day I asked about it on here.
Thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/syncdaemon/action_queue.py'
2--- ubuntuone/syncdaemon/action_queue.py 2009-12-01 21:54:29 +0000
3+++ ubuntuone/syncdaemon/action_queue.py 2009-12-03 19:00:26 +0000
4@@ -1856,7 +1856,7 @@
5 except HTTPError, e:
6 deferred.errback(Failure(e))
7
8- deferred.callback()
9+ deferred.callback(None)
10
11 def _run(self):
12 """

Subscribers

People subscribed via source and target branches