Merge lp:~nataliabidart/ubuntu/precise/ubuntu-sso-client/ubuntu-sso-client-2.99.1 into lp:ubuntu/precise/ubuntu-sso-client

Proposed by Natalia Bidart on 2012-01-03
Status: Merged
Merged at revision: 40
Proposed branch: lp:~nataliabidart/ubuntu/precise/ubuntu-sso-client/ubuntu-sso-client-2.99.1
Merge into: lp:ubuntu/precise/ubuntu-sso-client
Diff against target: 92 lines (+16/-6)
6 files modified
PKG-INFO (+1/-1)
debian/changelog (+10/-0)
debian/watch (+1/-1)
setup.py (+1/-1)
ubuntu_sso/credentials.py (+2/-2)
ubuntu_sso/utils/webclient/libsoup.py (+1/-1)
To merge this branch: bzr merge lp:~nataliabidart/ubuntu/precise/ubuntu-sso-client/ubuntu-sso-client-2.99.1
Reviewer Review Type Date Requested Status
Ken VanDine 2012-01-03 Approve on 2012-01-03
Review via email: mp+87403@code.launchpad.net

Description of the Change

- Updating debian/watch to download from latest milestone.
- New upstream release.

To post a comment you must log in.
Ken VanDine (ken-vandine) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'PKG-INFO'
2--- PKG-INFO 2011-12-20 17:33:13 +0000
3+++ PKG-INFO 2012-01-03 19:31:27 +0000
4@@ -1,6 +1,6 @@
5 Metadata-Version: 1.1
6 Name: ubuntu-sso-client
7-Version: 2.99.0
8+Version: 2.99.1
9 Summary: Ubuntu Single Sign-On client
10 Home-page: https://launchpad.net/ubuntu-sso-client
11 Author: Natalia Bidart
12
13=== modified file 'debian/changelog'
14--- debian/changelog 2011-12-21 10:28:36 +0000
15+++ debian/changelog 2012-01-03 19:31:27 +0000
16@@ -1,3 +1,13 @@
17+ubuntu-sso-client (2.99.1-0ubuntu1) UNRELEASED; urgency=low
18+
19+ * New upstream release:
20+ [ Guillermo Gonzalez <guillermo.gonzalez@canonical.com> ]
21+ - Remove _ping_url inlineCallbacks and make it return a deferred in
22+ order to make it work with twisted 11.1 (LP: #910163).
23+ * debian/watch: download from latest milestone.
24+
25+ -- Natalia Bidart (nessita) <natalia.bidart@canonical.com> Tue, 03 Jan 2012 16:02:33 -0300
26+
27 ubuntu-sso-client (2.99.0-0ubuntu1) precise; urgency=low
28
29 * New upstream release:
30
31=== modified file 'debian/watch'
32--- debian/watch 2011-12-20 17:21:53 +0000
33+++ debian/watch 2012-01-03 19:31:27 +0000
34@@ -1,2 +1,2 @@
35 version=3
36-http://launchpad.net/ubuntu-sso-client/stable-3-0/2.99.0/ .*/ubuntu-sso-client-([0-9.]+)\.tar\.gz
37+http://launchpad.net/ubuntu-sso-client/stable-3-0/2.99.1/ .*/ubuntu-sso-client-([0-9.]+)\.tar\.gz
38
39=== modified file 'setup.py'
40--- setup.py 2011-12-20 17:33:13 +0000
41+++ setup.py 2012-01-03 19:31:27 +0000
42@@ -364,7 +364,7 @@
43
44 DistUtilsExtra.auto.setup(
45 name='ubuntu-sso-client',
46- version='2.99.0',
47+ version='2.99.1',
48 license='GPL v3',
49 author='Natalia Bidart',
50 author_email='natalia.bidart@canonical.com',
51
52=== modified file 'ubuntu_sso/credentials.py'
53--- ubuntu_sso/credentials.py 2011-08-25 19:08:26 +0000
54+++ ubuntu_sso/credentials.py 2012-01-03 19:31:27 +0000
55@@ -43,6 +43,7 @@
56
57 from functools import wraps
58
59+from twisted.internet import defer
60 from twisted.internet.defer import inlineCallbacks, returnValue
61
62 from ubuntu_sso import NO_OP, utils
63@@ -216,7 +217,6 @@
64 self.denial_cb(app_name)
65
66 @handle_failures(msg='Problem opening the ping_url')
67- @inlineCallbacks
68 def _ping_url(self, app_name, email, credentials):
69 """Ping the self.ping_url with the email attached.
70
71@@ -245,7 +245,7 @@
72 # but the returned deferred will never be fired (nataliabidart).
73 response = urllib2.urlopen(request)
74 logger.debug('Url opened. Response: %s.', response.code)
75- returnValue(response)
76+ return defer.succeed(response)
77
78 @handle_exceptions(msg='Problem opening the Ubuntu SSO user interface')
79 def _show_ui(self, login_only):
80
81=== modified file 'ubuntu_sso/utils/webclient/libsoup.py'
82--- ubuntu_sso/utils/webclient/libsoup.py 2011-12-20 17:33:13 +0000
83+++ ubuntu_sso/utils/webclient/libsoup.py 2012-01-03 19:31:27 +0000
84@@ -33,7 +33,7 @@
85 def __init__(self, *args, **kwargs):
86 """Initialize this instance."""
87 super(WebClient, self).__init__(*args, **kwargs)
88- # pylint: disable=E0611
89+ # pylint: disable=E0611,F0401
90 from gi.repository import Soup, SoupGNOME
91 self.soup = Soup
92 self.session = Soup.SessionAsync()

Subscribers

People subscribed via source and target branches