Merge lp:~nataliabidart/ubuntu/maverick/ubuntu-sso-client/ubuntu-sso-client-1.0.0 into lp:ubuntu/maverick/ubuntu-sso-client

Proposed by Natalia Bidart on 2010-09-13
Status: Merged
Merged at revision: 13
Proposed branch: lp:~nataliabidart/ubuntu/maverick/ubuntu-sso-client/ubuntu-sso-client-1.0.0
Merge into: lp:ubuntu/maverick/ubuntu-sso-client
Diff against target: 143 lines (+26/-18)
7 files modified
PKG-INFO (+1/-13)
debian/changelog (+14/-0)
debian/control (+1/-0)
setup.py (+1/-1)
ubuntu_sso/keyring.py (+2/-1)
ubuntu_sso/main.py (+3/-1)
ubuntu_sso/tests/test_keyring.py (+4/-2)
To merge this branch: bzr merge lp:~nataliabidart/ubuntu/maverick/ubuntu-sso-client/ubuntu-sso-client-1.0.0
Reviewer Review Type Date Requested Status
Ubuntu Development Team 2010-09-13 Pending
Review via email: mp+35292@code.launchpad.net

Description of the Change

Minor tweaks. Releasing 1.0.0.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'PKG-INFO'
2--- PKG-INFO 2010-09-08 19:25:02 +0000
3+++ PKG-INFO 2010-09-13 15:04:46 +0000
4@@ -1,6 +1,6 @@
5 Metadata-Version: 1.1
6 Name: ubuntu-sso-client
7-Version: 0.99.6
8+Version: 1.0.0
9 Summary: Ubuntu Single Sign-On client
10 Home-page: https://launchpad.net/ubuntu-sso-client
11 Author: Natalia Bidart
12@@ -8,16 +8,4 @@
13 License: GPL v3
14 Description: Desktop service to allow applications to sign into Ubuntu services via SSO
15 Platform: UNKNOWN
16-Requires: contrib.testing.testcase
17-Requires: dbus
18-Requires: gnomekeyring
19-Requires: gobject
20-Requires: gtk
21-Requires: mocker
22-Requires: oauth
23-Requires: twisted.internet
24-Requires: twisted.python
25-Requires: twisted.trial.unittest
26-Requires: webkit
27-Requires: xdg
28 Provides: ubuntu_sso
29
30=== modified file 'debian/changelog'
31--- debian/changelog 2010-09-09 15:03:00 +0000
32+++ debian/changelog 2010-09-13 15:04:46 +0000
33@@ -1,3 +1,17 @@
34+ubuntu-sso-client (1.0.0-0ubuntu1) UNRELEASED; urgency=low
35+
36+ * New upstream release:
37+
38+ [ Natalia B. Bidart <natalia.bidart@canonical.com> ]
39+ * Import of gui module is delayed until actually needed, to remove high
40+ level dependency against graphical modules.
41+
42+ [ Natalia B. Bidart <natalia.bidart@canonical.com> ]
43+ * Passing a second parameter 'None' to gnomekerying.create_sync (LP:
44+ #634465).
45+
46+ -- Natalia Bidart (nessita) <nataliabidart@gmail.com> Mon, 13 Sep 2010 11:43:43 -0300
47+
48 ubuntu-sso-client (0.99.6-0ubuntu1) maverick; urgency=low
49
50 * New upstream release (0.99.6):
51
52=== modified file 'debian/control'
53--- debian/control 2010-08-24 20:24:21 +0000
54+++ debian/control 2010-09-13 15:04:46 +0000
55@@ -15,6 +15,7 @@
56 XB-Python-Version: ${python:Versions}
57 Depends: ${misc:Depends},
58 ${python:Depends},
59+ dpkg (>=1.15.7.2),
60 python-dbus,
61 python-gnomekeyring,
62 python-gtk2,
63
64=== modified file 'setup.py'
65--- setup.py 2010-09-08 19:25:02 +0000
66+++ setup.py 2010-09-13 15:04:46 +0000
67@@ -86,7 +86,7 @@
68
69 DistUtilsExtra.auto.setup(
70 name='ubuntu-sso-client',
71- version='0.99.6',
72+ version='1.0.0',
73 license='GPL v3',
74 author='Natalia Bidart',
75 author_email='natalia.bidart@canonical.com',
76
77=== modified file 'ubuntu_sso/keyring.py'
78--- ubuntu_sso/keyring.py 2010-09-08 19:25:02 +0000
79+++ ubuntu_sso/keyring.py 2010-09-13 15:04:46 +0000
80@@ -58,6 +58,7 @@
81
82 class Keyring(object):
83 """A Keyring for a given application name."""
84+
85 KEYRING_NAME = "login"
86
87 def __init__(self, app_name):
88@@ -71,7 +72,7 @@
89 """Creates a keyring, or if it already exists, it does nothing."""
90 keyring_names = gnomekeyring.list_keyring_names_sync()
91 if not name in keyring_names:
92- gnomekeyring.create_sync(name)
93+ gnomekeyring.create_sync(name, None)
94
95 def _find_keyring_item(self, attr=None):
96 """Return the keyring item or None if not found."""
97
98=== modified file 'ubuntu_sso/main.py'
99--- ubuntu_sso/main.py 2010-09-08 19:25:02 +0000
100+++ ubuntu_sso/main.py 2010-09-13 15:04:46 +0000
101@@ -43,7 +43,7 @@
102 # pylint: enable=F0401
103 from oauth import oauth
104
105-from ubuntu_sso import DBUS_IFACE_USER_NAME, DBUS_IFACE_CRED_NAME, gui
106+from ubuntu_sso import DBUS_IFACE_USER_NAME, DBUS_IFACE_CRED_NAME
107 from ubuntu_sso.keyring import Keyring, get_token_name, U1_APP_NAME
108 from ubuntu_sso.logger import setup_logging
109
110@@ -555,6 +555,8 @@
111 win_id, login_only=False):
112 """Shows the UI so the user can login or register."""
113 try:
114+ # delay gui import to be able to function on non-graphical envs
115+ from ubuntu_sso import gui
116 gui_app = gui.UbuntuSSOClientGUI(app_name, tc_url,
117 help_text, win_id, login_only)
118 gui_app.connect(gui.SIG_LOGIN_SUCCEEDED, self._login_success_cb)
119
120=== modified file 'ubuntu_sso/tests/test_keyring.py'
121--- ubuntu_sso/tests/test_keyring.py 2010-09-08 19:25:02 +0000
122+++ ubuntu_sso/tests/test_keyring.py 2010-09-13 15:04:46 +0000
123@@ -93,9 +93,9 @@
124 """The keyring you are looking for may be here."""
125 return self.keyrings
126
127- def create_sync(self, name):
128+ def create_sync(self, name, password):
129 """Thanks, I'll create that keyring for you."""
130- self.keyrings.add(name)
131+ self.keyrings.add((name, password))
132
133 def is_available(self):
134 """A very available keyring."""
135@@ -163,6 +163,8 @@
136
137 self.assertEqual(len(self.mgk.store), 2)
138 self.assertEqual(len(self.mgk.deleted), 0)
139+ self.assertEqual(self.mgk.keyrings,
140+ set([(keyring.Keyring.KEYRING_NAME, None)]))
141
142 def test_delete_ubuntusso(self):
143 """Test that a given key is deleted."""

Subscribers

People subscribed via source and target branches

to all changes: