Merge lp:~nataliabidart/ubuntu-sso-client/store-creds into lp:ubuntu-sso-client

Proposed by Natalia Bidart on 2010-11-22
Status: Merged
Approved by: Natalia Bidart on 2010-11-24
Approved revision: 653
Merged at revision: 652
Proposed branch: lp:~nataliabidart/ubuntu-sso-client/store-creds
Merge into: lp:ubuntu-sso-client
Diff against target: 0 lines
To merge this branch: bzr merge lp:~nataliabidart/ubuntu-sso-client/store-creds
Reviewer Review Type Date Requested Status
Didier Roche 2010-11-22 Approve on 2010-11-23
Eric Casteleijn (community) 2010-11-22 Approve on 2010-11-22
Review via email: mp+41521@code.launchpad.net

Commit Message

* Credentials can now be stored (LP: #680253).

* Status from SSO is not case sensitive (LP: #653165).

Description of the Change

To test, please run this branch with the command:

killall ubuntu-sso-login; DEBUG=True PYTHONPATH=. ./bin/ubuntu-sso-login

And then, execute d-feet and connect to the Session bus. There, look for the com.ubuntu.sso service, /com/ubuntu/sso/credentials/ and CredentialsManagement interface. Execute the 'store_credentials' method with params such as:

'Hola Mundo', {'token': '3', 'token_key': '2', 'consumer_key': '1', 'consumer_secret': '0'}

And then check within seahorse that the token was successfully store under the token name 'Hola Mundo @ <computer host name>"

To post a comment you must log in.
Eric Casteleijn (thisfred) wrote :

Yep, works! Code looks good.

review: Approve
Didier Roche (didrocks) wrote :

Nice and worked!

However, how will it work in the ubiquity installer session (I think there is no gnome-keyring service there, but we will figure out).
Also, not sure about the parameters between the token, token_key, consumer_key, consumer_secret and knowing that the account is an ubuntuone account, but I think we will chat about that after alpha1 (not before, please, will get back to oneconf the week after alpha1!)

Thanks for your work there :)

review: Approve
Ubuntu One Auto Pilot (otto-pilot) wrote :

Voting does not meet specified criteria. Required: Approve >= 2, Disapprove == 0, Needs Fixing == 0, Needs Information == 0, Resubmit == 0. Got: 1 Approve.

Natalia Bidart (nataliabidart) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches