lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.91.1
- Get this branch:
- bzr branch lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.91.1
Branch merges
- Manuel de la Peña (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 603 lines (+352/-39)14 files modifiedbin/ubuntu-sso-login-qt (+3/-4)
data/qt/stylesheet.qss (+1/-0)
run-tests (+1/-1)
setup.py (+1/-0)
ubuntu_sso/main/tests/test_common.py (+12/-0)
ubuntu_sso/qt/main/__init__.py (+16/-5)
ubuntu_sso/qt/main/linux.py (+35/-0)
ubuntu_sso/qt/main/tests/__init__.py (+17/-0)
ubuntu_sso/qt/main/tests/test_main.py (+42/-10)
ubuntu_sso/qt/main/windows.py (+46/-0)
ubuntu_sso/qt/proxy_dialog.py (+31/-2)
ubuntu_sso/qt/tests/test_proxy_dialog.py (+137/-16)
ubuntu_sso/utils/webclient/qtnetwork.py (+2/-1)
ubuntu_sso/utils/webclient/tests/test_webclient.py (+8/-0)
Related bugs
Bug #960481: Proxy credentials dialog does not work on windows | Medium | Fix Released | |
Bug #961315: Qt UI: when resetting my password using an invalid reset code, the operation fails and no error is shown | High | Fix Released | |
Bug #961346: Qt client looks bad with dark color schemes | Medium | Fix Released | |
Bug #961511: Backend get stuck and the ui is not responding | High | Fix Released | |
Bug #965377: SSO is not working | High | Fix Released |
Related blueprints
Branch information
Recent revisions
- 830. By Diego Sarmentero
-
- Updating from trunk up to revno 930:
[ Alejandro J. Cura <email address hidden> ]
- Do not allow ssl errors to be ignored (LP: #959390).
- Handle wrong credentials properly in qtnetwork webclient
(LP: #957317).
- Use HTTPClientFactory to allow replacing the reactor used to connect
(LP: #929207).[ Diego Sarmentero <email address hidden> ]
- Decode the content of help_text (LP: #951371).
- Removed the title from the reset page.
- Adding missing file for translation (LP: #951376).
- Adding a general error message when the argument received by
build_general_ error_message is not a dict (LP: #865176).
- Adding some checks to setup_page (LP: #951461).
- Adding a padding to the right margin of the reset layout, and align
one of its layout to the left (LP: #945065).
- Executing hide_error when the user click the refresh captcha link,
not inside of the _refresh_captcha method, because this is executed
automatically when a captcha error is generated, so we will always
miss the error message (LP: #955010).
- Removing the align property from the label that wasn't necessary
and was breakint the work wrap. Also adjust the height of the widget
depending if it has more than one line (LP: #940392).
- Improve logging operations (LP: #934500).
- Making LINK_STYLE to be unicode (LP: #950953).
- Setting the window title equal to the app_name (LP: #949744).
- The _move_to_email_verificat ion_page wasn't receiving the params
that the signal emits (LP: #945066).[ Jeremy Bicha <email address hidden> ]
- Improve the grammar for the CLOSE_AND_SETUP_LATER button text
(LP: #949978).[ Manuel de la Pena <email address hidden> ]
- Changed the way in which we deal with proxies to work around bugs
found in the QNetworkAccessManager (LP: #957313).
- Stopped listening to the proxyAuthenticationRequired to avoid the
dialog showing more than once (LP: #957170)
- Made changes in the way the webclient is selected to ensure that qt
is used when possible (LP: #957169)
- Connected the WebKit browser correctly so that the tc page gets
loaded (LP: #933081).
- Added code to check if the browser with the t&c was already loaded.
If it is just show the t&c page, otherwise perform the request
(LP: #956185).
- Added a translatable string to give more context of the ssl cert
info to the user (LP: #948119).
- Provided the logic required for the Qt webclient implementation to
detect ssl errors and spawn the ssl dialog to allow the user accept
the ssl cert exceptions (LP: #948134).
- Changed the qt webclient implementation to use a proxy factory so
that the correct proxy is chosen according to the request
(LP: #950088).
- Added the required code to allow the webclient use authenticated
proxies and request the creds when needed (LP: #933727).[ Natalia B. Bidart <email address hidden> ]
- The tooltip should not be shown for titles and subtitles when
no cut off was needed (LP: #949741).
- Making the WizardHeader a reusable class.
- Added some minor logging to build_general_error_msg.
- Improved code for the 'sign in' button validation.[ Roberto Alsina <email address hidden> ]
- Made the ubuntu-sso-proxy- creds script crossplatform (LP: #958884).
- Added .exe to the constant for binary names if needed (LP: #958778).
- Enable platform-specific styling (LP: #953318).
- Return the executable's dirname as BIN_DIR for frozen binaries
(LP: #956187).
- Only import DBus on Linux (LP: #956304).
- Fixed tests so they work under non-ascii locales (LP: #951716).[ Rodney Dawes <email address hidden> ]
- Don't hard-code font sizes
- Remove usage of weight property as a numeric; just use bold
property instead (LP: #953062). - 828. By Natalia Bidart
-
- Updating from trunk up to revno 901:
[ Diego Sarmentero <email address hidden> ]
- Hide the errors label on refresh captcha (LP: #947202).
- Changed the name of the function assigned to the lambda that is called
on passwordChanged signal from reset_password_page (LP: #945080).
- Made on_user_validated also emit stopProcessing so callers can hide
any processing overlay they are showing (LP: #945094).
- Fixed: Qt UI: there is a Back button in the "Enter verification page"
(LP: #944769).
- Fixed: Qt UI: there is not loading overvaly while validating an
email address (LP: #944767).
- Fixed: Qt UI: clicking on the "Set Up Account" button takes me
instantly to the verification page, even if there are form errors
(LP: #934502).
- Fix: [UIFe] Improve the display of errors in the Qt UI (LP: #938604).
- Fix: Qt UI: center when first opening (LP: #934173).
- Fixed: The header in the pages is above the overlay (LP: #934523).
- Fixed: [UIFE] The padding of the wizard pages in the Qt UI is not
correct (LP: #934519).[ Manuel de la Pena <email address hidden> ]
- Ensure that the strings used in sso do not have "ubuntu one" in them
(LP: #933729).
- Ensure that the strings used are the ones provided by design
(LP: #937905).
- Added the dialog that will be used to show that a certificate has issues
(LP: #933729).[ Natalia B. Bidart <email address hidden> ]
- Add proper titles and subtitles for the Login and Forgot password
pages (LP: #945061).
- Made UI modules to setup the gui logging logger (LP: #947469).
- Fallback to the GTK+ UI when the specified ui_executable does
not exist (LP: #939821).
- Move the 'choose sign in page' to client code (U1 control panel
in this case) (LP: #933576).
- Make use of the 'login_only' parameter that is being passed to the
UbuntuSSOWizard (LP: #939558).
- Stop using is_reactor_installed since is buggy (LP: #933644).
- Do not mask ImportError by importing inside a function (LP: #939173).
- No more strings coming up from the Designer ui files (LP: #938626).[ Roberto Alsina <email address hidden> ]
- Made the network detection code return ONLINE if NM is not available
(but still UNKNOWN if it's available and fails) (LP: #939703). - 826. By Diego Sarmentero
-
- Updating from trunk up to revno 882:
[ Diego Sarmentero <email address hidden> ]
- Fixed: Captcha is failing for the Qt UI (LP: #933679).
- Add stylesheets for the Qt UI.
- Fixed: Qt UI: must call the backend passing reply_handler
and error_handler (LP: #931452).[ Natalia B. Bidart <email address hidden> ]
- Make gettext return unicode strings. Also, transform arguments passed to
the GLib spawnner to bytes (LP: #933632).
- Fix lint issue on nightlies build (LP: #934488).
- Try to load the qt main/ implementation when possible, if not default
to the glib (LP: #933534).
- Make the bin_dir discoverable when running from the system installation
(LP: #933039).[ Roberto Alsina <email address hidden> ]
- Implement timeout_func for the Qt frontend (LP: #933758). - 824. By Natalia Bidart
-
- Updating from trunk up to revno 874:
[ Alejandro J. Cura <email address hidden> ]
- Use parameters set in the url for the OAuth signature (LP: #927664).
- libsoup bindings need flattening to work around nul bytes in content
(LP: #921822).
- Replace urllib2.Request with common web-client (LP: #884972).
- Replace urllib2.urlopen with common web-client (LP: #884975).
- Fix tests failing in sso with test_webclient (LP: #920591).[ Diego Sarmentero <email address hidden> ]
- Fixed: Qt UI: after clicking on "I've forgotten my password",
and entering an email, nothing happens (LP: #931577).
- Fixed: Qt UI must return ubuntu_sso.USER_ SUCCESS and
ubuntu_sso.USER_ CANCELLATION accordingly (LP. #930718).
- Fixed: Qt UI: congratulations page is empty (LP: #930720).
- Fixed: Qt UI: "I've forgotten my password" button can not be
clicked (LP: #930722)
- Fixed: Qt UI must return ubuntu_sso.USER_ SUCCESS and
ubuntu_sso.USER_ CANCELLATION accordingly (LP: #930718).
- Fixed: Qt UI: when calling login or validate_email,
should pass the ping_url (LP: #930724).
- Added signals for the different pages, letting the wizard decide
what to do in each case.
- Refactor the pages and controller in sso (LP: #929686).
- Migrate SSO Pages from the Wizard to SSO (LP: #925531).[ Manuel de la Pena <email address hidden> ]
- Adds the code that will load the creds from the keyring when we retry.
- Adds the script that allows to launch the creds dialog.
Adds tests for main.
- Allows the creds dialog to store the credentials in the keyring
(LP: #929451).
- Adds the credentials dialog with nearly no functionality to the project
(LP: #916029).
- Adds support for username:password@ domain urls in the qt implementation
of the webclient.[ Natalia B. Bidart <email address hidden> ]
- Proper name in setup.py for the proxy credentials executable
(LP: #932328).
- No more 'Congratulations, app_name has installed' message since
we're not installing (LP: #931574).
- Refactored logic on setup_account_page.py to displya terms and/or
privacy links properly (LP: #931589).
- Unified UI parse_args and have them accepting a policy_url param
(LP: #931464).
- Make the UI runner use the absolute path to the UI executables
(LP: #930651).
- Allow callers pass a 'policy_url' parameter to use in the UIs
(LP: #930142).
- Execute the UI as a separated process from the sso main thread
(LP: #919330).
- Hold on to the Qprocess instance to avoid garbage collection
(LP: #930140).
- Move the ping method from the credentials module to the
UserManagement interface (LP: #929670).
- The Gtk UI must handle errors from dbus when calling the backend
(LP: #929820).
- Provide a helper to spawn programs from the main loop that is being
used by the SSO Service (LP: #920949).
- Install ui files consitently between Gtk and Qt (part of LP: #927994).
- Remove unused "thread_execute" function (LP: #928581).
- Delay twisted.internet. reactor and twisted.web import to avoid
ReactorAlreadyInstalledErr or (LP: #927788).
- Added a dedicated logger for the gui module.
- Migrated the GTK UI to use GI bindings (LP: #801111).
- Enabled libsoup backend for webclient so the GTK UI will work.
- Enabled the running of all the tests using the single command
./run-tests.
- Added an initial version of GLib and Qt mainloop integration
(needed to run all the tests).
- Provide a QT UI executable (LP: #925073).
- Add a method to obtain an OAuth signed uri.[ Rodney Dawes <email address hidden> ]
- Connect the activate-link button by hand to avoid Gtk-WARNING messages.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:ubuntu-sso-client