Merge lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.1 into lp:ubuntu-sso-client/stable-3-0

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 819
Merged at revision: 818
Proposed branch: lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.1
Merge into: lp:ubuntu-sso-client/stable-3-0
Diff against target: 41 lines (+3/-3)
2 files modified
ubuntu_sso/credentials.py (+2/-2)
ubuntu_sso/utils/webclient/libsoup.py (+1/-1)
To merge this branch: bzr merge lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.1
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+87378@code.launchpad.net

Commit message

[ Guillermo Gonzalez <email address hidden> ]
  - Remove _ping_url inlineCallbacks and make it return a deferred in order to
    make it work with twisted 11.1 (LP: #910163).
[ Rodney Dawes <email address hidden> ]
  - Disable a lint warning, to prevent builds failing on Lucid

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu_sso/credentials.py'
2--- ubuntu_sso/credentials.py 2011-08-22 16:21:36 +0000
3+++ ubuntu_sso/credentials.py 2012-01-03 16:18:29 +0000
4@@ -43,6 +43,7 @@
5
6 from functools import wraps
7
8+from twisted.internet import defer
9 from twisted.internet.defer import inlineCallbacks, returnValue
10
11 from ubuntu_sso import NO_OP, utils
12@@ -216,7 +217,6 @@
13 self.denial_cb(app_name)
14
15 @handle_failures(msg='Problem opening the ping_url')
16- @inlineCallbacks
17 def _ping_url(self, app_name, email, credentials):
18 """Ping the self.ping_url with the email attached.
19
20@@ -245,7 +245,7 @@
21 # but the returned deferred will never be fired (nataliabidart).
22 response = urllib2.urlopen(request)
23 logger.debug('Url opened. Response: %s.', response.code)
24- returnValue(response)
25+ return defer.succeed(response)
26
27 @handle_exceptions(msg='Problem opening the Ubuntu SSO user interface')
28 def _show_ui(self, login_only):
29
30=== modified file 'ubuntu_sso/utils/webclient/libsoup.py'
31--- ubuntu_sso/utils/webclient/libsoup.py 2011-12-19 19:42:29 +0000
32+++ ubuntu_sso/utils/webclient/libsoup.py 2012-01-03 16:18:29 +0000
33@@ -33,7 +33,7 @@
34 def __init__(self, *args, **kwargs):
35 """Initialize this instance."""
36 super(WebClient, self).__init__(*args, **kwargs)
37- # pylint: disable=E0611
38+ # pylint: disable=E0611,F0401
39 from gi.repository import Soup, SoupGNOME
40 self.soup = Soup
41 self.session = Soup.SessionAsync()

Subscribers

People subscribed via source and target branches