Merge lp:~nataliabidart/ubuntu-sso-client/improve-gui into lp:ubuntu-sso-client

[Natalia Bidart]

More improvements:

* T&C opens a embedded webkit browser showing the T&C text.
* Password fields now shown a help text.
* Spinner + label for "captcha loading" are now centered and with a fixed size. Still can't set the background to white as requested in the spec, GTK is making me crazy.

Next branch: avoid using a warning dialog for errors. Integrate some mechanism of test the rest of the screens.

[Rodrigo Moya (rodrigo-moya)]

This branch breaks the resizing of the dialog that you fixed in the previous branch. I guess you need to pass 'expand' and 'fill' arguments to the calls to the box's pack_start method.

Also, the text for the password help looks really bad, justified to the right. Is that intended?

review: Needs Fixing

[Natalia Bidart (nataliabidart)]

> This branch breaks the resizing of the dialog that you fixed in the previous
> branch. I guess you need to pass 'expand' and 'fill' arguments to the calls to
> the box's pack_start method.
>
> Also, the text for the password help looks really bad, justified to the right.
> Is that intended?

All fixed. Sorry for the regression, I had to change the whole layout and forgot to set that back.

[lp:~nataliabidart/ubuntu-sso-client/improve-gui]

554. By Natalia Bidart on 2010-07-27

Email and password must not expand.

[Rodrigo Moya (rodrigo-moya)]

Looks good now.

About the white background, please don't do that. If the user changes to a theme that has white (or any other bright color) as the font color, text won't be seen. So, just leave it as the default, or use a color from the theme (the entry/text view default background color)

review: Approve

[John Lenton (chipaca)]

I think this is great. I wait anxiously for improvements that are in the pipeline :)

review: Approve

=== modified file 'data/ui.glade'
--- data/ui.glade	2010-07-22 13:17:10 +0000
+++ data/ui.glade	2010-07-27 14:29:41 +0000
@@ -30,18 +30,10 @@
               <placeholder/>
             </child>
             <child>
-              <object class="GtkTable" id="email_password_table">
+              <object class="GtkHBox" id="emails_hbox">
                 <property name="visible">True</property>
-                <property name="n_rows">2</property>
-                <property name="n_columns">2</property>
-                <property name="column_spacing">5</property>
-                <property name="row_spacing">5</property>
-                <child>
-                  <placeholder/>
-                </child>
-                <child>
-                  <placeholder/>
-                </child>
+                <property name="spacing">5</property>
+                <property name="homogeneous">True</property>
                 <child>
                   <placeholder/>
                 </child>
@@ -55,23 +47,63 @@
               </packing>
             </child>
             <child>
-              <object class="GtkHBox" id="captcha_loading">
-                <property name="visible">True</property>
-                <child>
-                  <object class="GtkLabel" id="captcha_loading_label">
+              <placeholder/>
+            </child>
+            <child>
+              <object class="GtkHBox" id="passwords_hbox">
+                <property name="visible">True</property>
+                <property name="spacing">5</property>
+                <property name="homogeneous">True</property>
+                <child>
+                  <placeholder/>
+                </child>
+                <child>
+                  <placeholder/>
+                </child>
+              </object>
+              <packing>
+                <property name="expand">False</property>
+                <property name="position">3</property>
+              </packing>
+            </child>
+            <child>
+              <object class="GtkLabel" id="password_help_label">
+                <property name="visible">True</property>
+                <property name="wrap">True</property>
+              </object>
+              <packing>
+                <property name="expand">False</property>
+                <property name="position">4</property>
+              </packing>
+            </child>
+            <child>
+              <object class="GtkAlignment" id="captcha_loading">
+                <property name="width_request">300</property>
+                <property name="height_request">60</property>
+                <property name="visible">True</property>
+                <property name="xscale">0</property>
+                <property name="yscale">0</property>
+                <child>
+                  <object class="GtkHBox" id="captcha_loading_hbox">
                     <property name="visible">True</property>
-                    <property name="xalign">1</property>
+                    <property name="spacing">5</property>
+                    <child>
+                      <placeholder/>
+                    </child>
+                    <child>
+                      <object class="GtkLabel" id="captcha_loading_label">
+                        <property name="visible">True</property>
+                      </object>
+                      <packing>
+                        <property name="expand">False</property>
+                        <property name="position">1</property>
+                      </packing>
+                    </child>
                   </object>
-                  <packing>
-                    <property name="position">0</property>
-                  </packing>
-                </child>
-                <child>
-                  <placeholder/>
                 </child>
               </object>
               <packing>
-                <property name="position">2</property>
+                <property name="position">5</property>
               </packing>
             </child>
             <child>
@@ -79,7 +111,7 @@
                 <property name="stock">gtk-missing-image</property>
               </object>
               <packing>
-                <property name="position">3</property>
+                <property name="position">6</property>
               </packing>
             </child>
             <child>
@@ -95,7 +127,7 @@
               </object>
               <packing>
                 <property name="expand">False</property>
-                <property name="position">5</property>
+                <property name="position">8</property>
               </packing>
             </child>
             <child>
@@ -116,14 +148,22 @@
                   </packing>
                 </child>
                 <child>
-                  <object class="GtkLinkButton" id="tc_button">
-                    <property name="label" translatable="yes">test me!</property>
+                  <object class="GtkHButtonBox" id="hbuttonbox3">
                     <property name="visible">True</property>
-                    <property name="can_focus">True</property>
-                    <property name="receives_default">True</property>
-                    <property name="has_tooltip">True</property>
-                    <property name="relief">none</property>
-                    <property name="xalign">0</property>
+                    <property name="layout_style">start</property>
+                    <child>
+                      <object class="GtkButton" id="tc_button">
+                        <property name="visible">True</property>
+                        <property name="can_focus">True</property>
+                        <property name="receives_default">True</property>
+                        <signal name="clicked" handler="on_tc_button_clicked"/>
+                      </object>
+                      <packing>
+                        <property name="expand">False</property>
+                        <property name="fill">False</property>
+                        <property name="position">0</property>
+                      </packing>
+                    </child>
                   </object>
                   <packing>
                     <property name="position">1</property>
@@ -132,7 +172,7 @@
               </object>
               <packing>
                 <property name="expand">False</property>
-                <property name="position">6</property>
+                <property name="position">9</property>
               </packing>
             </child>
             <child>
@@ -157,7 +197,7 @@
                 </child>
                 <child>
                   <object class="GtkButton" id="join_ok_button">
-                    <property name="label">gtk-media-next</property>
+                    <property name="label">gtk-go-forward</property>
                     <property name="visible">True</property>
                     <property name="can_focus">True</property>
                     <property name="receives_default">True</property>
@@ -173,7 +213,7 @@
               </object>
               <packing>
                 <property name="expand">False</property>
-                <property name="position">7</property>
+                <property name="position">10</property>
               </packing>
             </child>
           </object>
@@ -247,6 +287,53 @@
             <property name="position">4</property>
           </packing>
         </child>
+        <child>
+          <object class="GtkVBox" id="tc_browser_vbox">
+            <property name="visible">True</property>
+            <child>
+              <object class="GtkScrolledWindow" id="tc_browser_window">
+                <property name="visible">True</property>
+                <property name="can_focus">True</property>
+                <property name="hscrollbar_policy">never</property>
+                <property name="vscrollbar_policy">automatic</property>
+                <child>
+                  <placeholder/>
+                </child>
+              </object>
+              <packing>
+                <property name="position">0</property>
+              </packing>
+            </child>
+            <child>
+              <object class="GtkHButtonBox" id="hbuttonbox4">
+                <property name="visible">True</property>
+                <property name="layout_style">end</property>
+                <child>
+                  <object class="GtkButton" id="tc_back_button">
+                    <property name="label">gtk-go-back</property>
+                    <property name="visible">True</property>
+                    <property name="can_focus">True</property>
+                    <property name="receives_default">True</property>
+                    <property name="use_stock">True</property>
+                    <signal name="clicked" handler="on_tc_back_button_clicked"/>
+                  </object>
+                  <packing>
+                    <property name="expand">False</property>
+                    <property name="fill">False</property>
+                    <property name="position">0</property>
+                  </packing>
+                </child>
+              </object>
+              <packing>
+                <property name="expand">False</property>
+                <property name="position">1</property>
+              </packing>
+            </child>
+          </object>
+          <packing>
+            <property name="position">5</property>
+          </packing>
+        </child>
       </object>
     </child>
   </object>

=== modified file 'ubuntu_sso/gui.py'
--- ubuntu_sso/gui.py	2010-07-22 13:17:10 +0000
+++ ubuntu_sso/gui.py	2010-07-27 14:29:41 +0000
@@ -22,11 +22,13 @@
 
 import gettext
 import gtk
+import webkit
 
 _ = gettext.gettext
 
 
 HELP_TEXT_COLOR = gtk.gdk.color_parse("#9c9a94")
+TC_URI = 'http://one.ubuntu.com/terms/'
 
 
 class LabeledEntry(gtk.Entry):
@@ -79,8 +81,6 @@
 class UserRegistrationGUI(object):
     """User registration GUI."""
 
-    TC_URI = 'http://one.ubuntu.com/terms/'
-
     # Initial texts
     JOIN_HEADER_LABEL = _('Join') + ' <b>Ubuntu One</b>'
     NAME_ENTRY = _('Name')
@@ -96,18 +96,18 @@
                        'and try entering them again.')
     PASSWORD_MISMATCH = _('The passwords don\'t match, please double check '
                           'and try entering them again.')
-    PASSWORD_TOO_WEAK = _('The password must have at least 8 characters, one '
-                          'upper case and one number.')
+    PASSWORD_HELP = _('The password must have a minimum of 8 characters '
+                      'and include one uppercase character and one number.')
     TC_NOT_ACCEPTED = _('Agreeing to the Ubuntu One Terms & Conditions is '
                         'required to subscribe')
-    CAPTCHA_LOADING = _('loading captcha image...')
+    CAPTCHA_LOADING = _('Loading ...')
     VERIFY_EMAIL_LABEL = _("""Enter verification code.
 
-A four digit verification code has just been sent t your email address.
+A four digit verification code has just been sent to your email address.
 Please enter this code below.""")
     EMAIL_TOKEN_ENTRY = _('Enter code verification here')
 
-    def __init__(self, backend=None, close_callback=None):
+    def __init__(self, backend=None, close_callback=None, tc_uri=None):
         """Create the GUI and initialize widgets."""
 
         if backend is not None:
@@ -115,6 +115,13 @@
             self._captcha_filename = self._mktemp()
             self.backend.generate_captcha(filename=self._captcha_filename)
 
+        self.close_callback = close_callback
+
+        if tc_uri is None:
+            self.tc_uri = TC_URI
+        else:
+            self.tc_uri = tc_uri
+
         ui_filename = os.path.abspath(os.path.join(os.path.dirname(__file__),
                                       os.pardir, 'data', 'ui.glade'))
         self.builder = gtk.Builder()
@@ -124,13 +131,29 @@
         self.text_widgets = ('name_entry', 'email1_entry', 'email2_entry',
                              'password1_entry', 'password2_entry',
                              'captcha_solution_entry', 'email_token_entry')
-        widgets = ('join_header_label', 'join_window', 'join_cancel_button',
-                   'join_ok_button', 'email_password_table', 'tc_button',
-                   'yes_to_updates_checkbutton', 'yes_to_tc_checkbutton',
-                   'enter_details_vbox', 'processing_vbox',
-                   'captcha_loading_label', 'captcha_image', 'captcha_loading',
-                   'verify_email_vbox', 'verify_email_label')
-                  #+ self.text_widgets
+        widgets = (
+            'captcha_image',
+            'captcha_loading',
+            'captcha_loading_label',
+            'captcha_loading_hbox',
+            'emails_hbox',
+            'enter_details_vbox',
+            'join_cancel_button',
+            'join_header_label',
+            'join_ok_button',
+            'join_window',
+            'password_help_label',
+            'passwords_hbox',
+            'processing_vbox',
+            'tc_back_button',
+            'tc_button',
+            'tc_browser_vbox',
+            'tc_browser_window',
+            'verify_email_label',
+            'verify_email_vbox',
+            'yes_to_tc_checkbutton',
+            'yes_to_updates_checkbutton',
+        )
         for name in widgets:
             widget = self.builder.get_object(name)
             assert widget is not None, '%s should be a valid object.' % name
@@ -147,20 +170,24 @@
 
         self.enter_details_vbox.pack_start(self.name_entry, expand=False)
         self.enter_details_vbox.reorder_child(self.name_entry, 0)
-        self.email_password_table.attach(self.email1_entry, 0, 1, 0, 1)
-        self.email_password_table.attach(self.email2_entry, 1, 2, 0, 1)
-        self.email_password_table.attach(self.password1_entry, 0, 1, 1, 2)
-        self.email_password_table.attach(self.password2_entry, 1, 2, 1, 2)
+        self.emails_hbox.pack_start(self.email1_entry)
+        self.emails_hbox.pack_start(self.email2_entry)
+        self.passwords_hbox.pack_start(self.password1_entry)
+        self.passwords_hbox.pack_start(self.password2_entry)
+        self.password_help_label.set_text(self.PASSWORD_HELP)
+
         self.enter_details_vbox.pack_start(self.captcha_solution_entry,
                                            expand=False)
-        self.enter_details_vbox.reorder_child(self.captcha_solution_entry, 3)
+        self.enter_details_vbox.reorder_child(self.captcha_solution_entry, 5)
 
         self._set_captcha_loading()
 
         self.yes_to_updates_checkbutton.set_label(self.YES_TO_UPDATES)
         self.yes_to_tc_checkbutton.set_label(self.YES_TO_TC)
+
         self.tc_button.set_label(self.TC)
-        self.tc_button.set_uri(self.TC_URI)
+        self.tc_browser = webkit.WebView()
+        self.tc_browser_window.add(self.tc_browser)
 
         self.verify_email_label.set_text(self.VERIFY_EMAIL_LABEL)
         self.verify_email_vbox.pack_start(self.email_token_entry, expand=False)
@@ -170,13 +197,14 @@
                                                 buttons=gtk.BUTTONS_CLOSE,
                                                 flags=gtk.DIALOG_MODAL)
 
-        self.close_callback = close_callback
         # XXX: hack to not have the focus on the name entry
         self.join_cancel_button.grab_focus()
 
         self.enter_details_vbox.show()
         self.processing_vbox.hide()
         self.verify_email_vbox.hide()
+        self.tc_browser_vbox.hide()
+
         self.join_window.show()
 
         # hack until backend notifies the success of a registration
@@ -185,10 +213,18 @@
     def _set_captcha_loading(self):
         """Present a spinner to the user while the captcha is downloaded."""
         self.join_ok_button.set_sensitive(False)
+
         spinner = gtk.Spinner()
         spinner.start()
-        self.captcha_loading.pack_start(spinner)
+        self.captcha_loading_hbox.pack_start(spinner, expand=False)
+        self.captcha_loading_hbox.reorder_child(spinner, 0)
         self.captcha_loading_label.set_text(self.CAPTCHA_LOADING)
+
+        # XXX: currently not working :-/
+        #white = gtk.gdk.Color('white')
+        #self.captcha_loading.modify_fg(gtk.STATE_NORMAL, white)
+        #self.captcha_loading.modify_base(gtk.STATE_NORMAL, white)
+
         self.captcha_loading.show_all()
 
     def _set_processing_screen(self):
@@ -238,7 +274,7 @@
         if (len(password1) < 8 or
             re.search('[A-Z]', password1) is None or
             re.search('\d+', password1) is None):
-            self.warning_dialog.set_markup(self.PASSWORD_TOO_WEAK)
+            self.warning_dialog.set_markup(self.PASSWORD_HELP)
             self.warning_dialog.run()
             self.warning_dialog.hide()
             return
@@ -254,6 +290,24 @@
         self.verify_email_vbox.hide()
         self._set_processing_screen()
 
+    def on_tc_button_clicked(self, *args, **kwargs):
+        """T & C button was clicked, show the browser with them."""
+        self.tc_browser.open(self.tc_uri)
+
+        self.enter_details_vbox.hide()
+        self.processing_vbox.hide()
+        self.verify_email_vbox.hide()
+        self.tc_browser_vbox.show_all()
+
+    def on_tc_back_button_clicked(self, *args, **kwargs):
+        """T & C 'back' button was clicked, return to the previous screen."""
+        self.enter_details_vbox.show()
+        self.processing_vbox.hide()
+        self.verify_email_vbox.hide()
+        self.tc_browser_vbox.hide()
+
+    # backend callbacks
+
     def on_registration_successful(self):
         """Registration can go on, user needs to verify email."""
         self.enter_details_vbox.hide()
@@ -262,6 +316,7 @@
 
     def on_captcha_generated(self, captcha_id):
         """Captcha image has been generated and is available to be shown."""
+        self.captcha_loading.hide()
         self.join_ok_button.set_sensitive(True)
         self.captcha_image.show()
         self.captcha_image.set_from_file(self._captcha_filename)

=== modified file 'ubuntu_sso/tests/test_gui.py'
--- ubuntu_sso/tests/test_gui.py	2010-07-21 16:03:44 +0000
+++ ubuntu_sso/tests/test_gui.py	2010-07-27 14:29:41 +0000
@@ -208,7 +208,9 @@
         """Init."""
         super(UserRegistrationGUITestCase, self).setUp()
         self.backend = FakedSSOBackend()
-        self.ui = gui.UserRegistrationGUI(backend=self.backend)
+        self.tc_uri = 'http://localhost'
+        self.ui = gui.UserRegistrationGUI(backend=self.backend,
+                                          tc_uri=self.tc_uri)
         self.patch(self.ui.warning_dialog, 'run', NO_OP)  # do not open dialogs
 
     def tearDown(self):
@@ -292,6 +294,8 @@
                          msg % ('processing_vbox', 'not '))
         self.assertFalse(self.ui.verify_email_vbox.get_property('visible'),
                          msg % ('verify_email_vbox', 'not '))
+        self.assertFalse(self.ui.tc_browser_vbox.get_property('visible'),
+                         msg % ('tc_browser_vbox', 'not '))
 
     def test_join_ok_button_clicked(self):
         """Clicking 'join_ok_button' presents the processing vbox."""
@@ -304,6 +308,8 @@
                          msg % ('processing_vbox', ''))
         self.assertFalse(self.ui.verify_email_vbox.get_property('visible'),
                          msg % ('verify_email_vbox', 'not '))
+        self.assertFalse(self.ui.tc_browser_vbox.get_property('visible'),
+                         msg % ('tc_browser_vbox', 'not '))
 
     def test_processing_vbox_displays_an_active_spinner(self):
         """When processing the registration, an active spinner is shown."""
@@ -329,12 +335,12 @@
         self.assertTrue(self.ui.captcha_loading.get_property('visible'),
                         'the captcha_loading vbox should be visible.')
 
-        children = self.ui.captcha_loading.get_children()
+        children = self.ui.captcha_loading_hbox.get_children()
         self.assertEqual(2, len(children),
                          'captcha_loading must have two children.')
-        self.assertEqual(self.ui.captcha_loading_label, children[0],
-                         'captcha_loading must have a label as child.')
-        spinner = children[-1]
+        self.assertIn(self.ui.captcha_loading_label, children,
+                      'captcha_loading must have a label as child.')
+        spinner = children[0]
         self.assertIsInstance(spinner, gtk.Spinner)
         self.assertTrue(self.ui.captcha_loading_label.get_property('visible'),
                         'the captcha_loading_label should be visible.')
@@ -343,7 +349,7 @@
         self.assertTrue(spinner.get_property('active'),
                         'the processing_spinner should be active.')
 
-    def test_veridy_email_label_display_correct_info(self):
+    def test_verify_email_label_display_correct_info(self):
         """The verify_email_label display VERIFY_EMAIL_LABEL."""
         msg = 'verify_email_label must read "%s" (got "%s" instead).'
         actual = self.ui.verify_email_label.get_text()
@@ -360,18 +366,47 @@
                          msg % ('processing_vbox', 'not '))
         self.assertTrue(self.ui.verify_email_vbox.get_property('visible'),
                          msg % ('verify_email_vbox', ''))
-
-    def test_tc_button_is_a_link_button(self):
-        """Terms & Conditions is a link button."""
-        self.assertIsInstance(self.ui.tc_button, gtk.LinkButton)
+        self.assertFalse(self.ui.tc_browser_vbox.get_property('visible'),
+                         msg % ('tc_browser_vbox', 'not '))
+
+    def test_tc_button_clicked_morphs_into_tc_browser_vbox(self):
+        """Terms & Conditions morphs to a browser window."""
+        self.ui.tc_button.clicked()
+
+        msg = '"%s" must %sbe visible after registration_successful.'
+        self.assertFalse(self.ui.enter_details_vbox.get_property('visible'),
+                         msg % ('enter_details_vbox', 'not '))
+        self.assertFalse(self.ui.processing_vbox.get_property('visible'),
+                         msg % ('processing_vbox', 'not '))
+        self.assertFalse(self.ui.verify_email_vbox.get_property('visible'),
+                         msg % ('verify_email_vbox', 'not '))
+        self.assertTrue(self.ui.tc_browser_vbox.get_property('visible'),
+                         msg % ('tc_browser_vbox', ''))
+
+    def test_tc_back_clicked_returns_to_previous_screen(self):
+        """Terms & Conditions back button return to previous screen."""
+        self.ui.tc_button.clicked()
+        self.ui.tc_back_button.clicked()
+
+        msg = '"%s" must %sbe visible after registration_successful.'
+        self.assertTrue(self.ui.enter_details_vbox.get_property('visible'),
+                         msg % ('enter_details_vbox', ''))
+        self.assertFalse(self.ui.processing_vbox.get_property('visible'),
+                         msg % ('processing_vbox', 'not '))
+        self.assertFalse(self.ui.verify_email_vbox.get_property('visible'),
+                         msg % ('verify_email_vbox', 'not '))
+        self.assertFalse(self.ui.tc_browser_vbox.get_property('visible'),
+                         msg % ('tc_browser_vbox', 'not '))
 
     def test_tc_button_has_the_proper_wording(self):
-        """Terms & Conditions is a link button."""
+        """Terms & Conditions has the proper wording."""
         self.assertEqual(self.ui.tc_button.get_label(), self.ui.TC)
 
-    def test_tc_button_has_the_proper_uri(self):
-        """Terms & Conditions is a link button."""
-        self.assertEqual(self.ui.tc_button.get_uri(), self.ui.TC_URI)
+    def test_tc_browser_opens_the_proper_uri(self):
+        """Terms & Conditions browser shows the proper uri."""
+        self.patch(self.ui.tc_browser, 'open', self._set_called)
+        self.ui.tc_button.clicked()
+        self.assertEqual(self._called, ((self.tc_uri,), {}))
 
     def test_join_ok_button_is_disabled_until_captcha_is_available(self):
         """The join_ok_button is not sensitive until captcha is available."""
@@ -382,6 +417,12 @@
         self.ui.on_captcha_generated(captcha_id='something')
         self.assertTrue(self.ui.join_ok_button.is_sensitive())
 
+    def test_captcha_loading_is_hid_when_captcha_is_available(self):
+        """The captcha_loading is hid when captcha is available."""
+        self.ui.on_captcha_generated(captcha_id='something')
+        self.assertFalse(self.ui.captcha_loading.get_property('visible'),
+                         'captcha_loading is not visible.')
+
     def test_captcha_image_is_requested_as_startup(self):
         """The captcha image is requested at startup."""
         # assert generate_captcha was called
@@ -435,6 +476,13 @@
         self.assertEqual(self._dummy, self.ui.EMAIL_MISMATCH)
         self.assertTrue(self._called, 'warning_dialog must be run.')
 
+    def test_password_help_is_always_shown(self):
+        """Password help text is correctly displayed."""
+        self.assertTrue(self.ui.password_help_label.get_property('visible'),
+                        'password help text is visible.')
+        self.assertEqual(self.ui.password_help_label.get_text(),
+                         self.ui.PASSWORD_HELP)
+
     def test_warning_is_shown_if_password_mismatch(self):
         """A warning message is shown if password doesn't match."""
         # email will match
@@ -455,7 +503,7 @@
         self.ui.email1_entry.set_text(EMAIL)
         self.ui.email2_entry.set_text(EMAIL)
 
-        msg = 'PASSWORD_TOO_WEAK should be set in warning_dialog for "%s".'
+        msg = 'PASSWORD_HELP should be set in warning_dialog for "%s".'
         # password will match but will be too weak
         for w in ('', 'h3lloWo', PASSWORD.lower(), 'helloWorld'):
             self.ui.password1_entry.set_text(w)
@@ -463,7 +511,7 @@
 
             self.ui.join_ok_button.clicked()  # submit form
 
-            self.assertEqual(self._dummy, self.ui.PASSWORD_TOO_WEAK, msg % w)
+            self.assertEqual(self._dummy, self.ui.PASSWORD_HELP, msg % w)
             self.assertTrue(self._called, 'warning_dialog must be run.')
 
             self._dummy = None