Merge lp:~nataliabidart/ubuntu-sso-client/displayname into lp:ubuntu-sso-client
Proposed by
Natalia Bidart
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Natalia Bidart | ||||
Approved revision: | 680 | ||||
Merged at revision: | 682 | ||||
Proposed branch: | lp:~nataliabidart/ubuntu-sso-client/displayname | ||||
Merge into: | lp:ubuntu-sso-client | ||||
Diff against target: |
242 lines (+35/-36) 8 files modified
ubuntu_sso/account.py (+7/-4) ubuntu_sso/gtk/gui.py (+8/-10) ubuntu_sso/gtk/tests/test_gui.py (+1/-6) ubuntu_sso/main/__init__.py (+2/-2) ubuntu_sso/main/linux.py (+3/-3) ubuntu_sso/tests/main/test_common.py (+3/-2) ubuntu_sso/tests/main/test_linux.py (+7/-7) ubuntu_sso/tests/test_account.py (+4/-2) |
||||
To merge this branch: | bzr merge lp:~nataliabidart/ubuntu-sso-client/displayname | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Eric Casteleijn (community) | Approve | ||
Martin Albisetti (community) | Approve | ||
Review via email: mp+54216@code.launchpad.net |
Commit message
- Register now uses the 'displayname' field to pass it on to SSO as display name (LP: #709494).
Description of the change
To test, run in this branch:
DEBUG=True PYTHONPATH=. ./bin/ubuntu-
From d-feet, run the 'register' method for the /com/ubuntu/
'A testing App', {}
and once you're properly registered, check on https:/
To post a comment you must log in.
Tests pass, code looks good, and manual testing shows it works.