Merge lp:~nataliabidart/software-center/lost-in-translation into lp:software-center

[Natalia Bidart]

- Pass the missing "self" argument to the super(ish) call.

[Michael Vogt (mvo)]

Looks good, thanks for the fix.

review: Approve

=== modified file 'softwarecenter/ui/gtk3/panes/installedpane.py'
--- softwarecenter/ui/gtk3/panes/installedpane.py	2012-06-18 20:26:49 +0000
+++ softwarecenter/ui/gtk3/panes/installedpane.py	2012-06-26 13:30:18 +0000
@@ -690,7 +690,7 @@
 
     def on_application_selected(self, appview, app):
         """Callback for when an app is selected."""
-        SoftwarePane.on_application_selected(appview, app)
+        SoftwarePane.on_application_selected(self, appview, app)
         self.current_appview_selection = app
 
     def enter_page(self, page, state):

=== modified file 'tests/gtk3/test_installedpane.py'
--- tests/gtk3/test_installedpane.py	2012-05-30 18:39:55 +0000
+++ tests/gtk3/test_installedpane.py	2012-06-26 13:30:18 +0000
@@ -11,39 +11,46 @@
 
 class TestInstalledPane(unittest.TestCase):
 
-    def test_installedpane(self):
+    def setUp(self):
         win = get_test_window_installedpane()
         self.addCleanup(win.destroy)
-        installedpane = win.get_data("pane")
+        self.pane = win.get_data("pane")
+
+    def test_installedpane(self):
         do_events_with_sleep()
         # safe initial show/hide label for later
-        initial_actionbar_label = installedpane.action_bar._label_text
+        initial_actionbar_label = self.pane.action_bar._label_text
         # do simple search
-        installedpane.on_search_terms_changed(None, "foo")
+        self.pane.on_search_terms_changed(None, "foo")
         do_events_with_sleep()
-        model = installedpane.app_view.tree_view.get_model()
+        model = self.pane.app_view.tree_view.get_model()
         # FIXME: len(model) *only* counts the size of the top level
         #        (category) hits. thats still ok, as non-apps will
         #        add the "system" category
         len_only_apps = len(model)
         # set to show nonapps
-        installedpane._show_nonapp_pkgs()
+        self.pane._show_nonapp_pkgs()
         do_events_with_sleep()
         len_with_nonapps = len(model)
         self.assertTrue(len_with_nonapps > len_only_apps)
         # set to hide nonapps again and ensure the size matches the
         # previous one
-        installedpane._hide_nonapp_pkgs()
+        self.pane._hide_nonapp_pkgs()
         do_events_with_sleep()
         self.assertEqual(len(model), len_only_apps)
         # clear sarch and ensure we get a expanded size again
-        installedpane.on_search_terms_changed(None, "")
+        self.pane.on_search_terms_changed(None, "")
         do_events_with_sleep()
         all_apps = len(model)
         self.assertTrue(all_apps > len_only_apps)
         # ensure we have the same show/hide info as initially
         self.assertEqual(initial_actionbar_label,
-                         installedpane.action_bar._label_text)
+                         self.pane.action_bar._label_text)
+
+    def test_application_selected(self):
+        the_app = object()
+        self.pane.on_application_selected(appview=None, app=the_app)
+        self.assertIs(self.pane.current_appview_selection, the_app)
 
 
 if __name__ == "__main__":