Merge lp:~nataliabidart/magicicada-client/avoid-import-error-precise into lp:magicicada-client

Proposed by Natalia Bidart
Status: Merged
Approved by: Natalia Bidart
Approved revision: 1414
Merged at revision: 1411
Proposed branch: lp:~nataliabidart/magicicada-client/avoid-import-error-precise
Merge into: lp:magicicada-client
Diff against target: 45 lines (+10/-3)
3 files modified
.bzrignore (+2/-2)
dependencies.txt (+1/-0)
ubuntuone/syncdaemon/utils.py (+7/-1)
To merge this branch: bzr merge lp:~nataliabidart/magicicada-client/avoid-import-error-precise
Reviewer Review Type Date Requested Status
Natalia Bidart Approve
Review via email: mp+271744@code.launchpad.net

Commit message

- Avoid "ImportError: cannot import name get_program_path" on precise.
- Added missing dependency on python-qt4-dbus.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2015-09-19 21:11:52 +0000
3+++ .bzrignore 2015-09-20 00:25:29 +0000
4@@ -11,8 +11,8 @@
5 *.pyc
6 *.service
7
8+.env
9+.protocol
10 clientdefs.py
11-env
12 logging.conf
13-.protocol
14 ubuntuone/storageprotocol
15
16=== modified file 'dependencies.txt'
17--- dependencies.txt 2015-09-19 23:31:26 +0000
18+++ dependencies.txt 2015-09-20 00:25:29 +0000
19@@ -4,6 +4,7 @@
20 python-gi
21 python-protobuf
22 python-pyinotify
23+python-qt4-dbus
24 python-qt4reactor
25 python-twisted
26 python-ubuntu-sso-client
27
28=== modified file 'ubuntuone/syncdaemon/utils.py'
29--- ubuntuone/syncdaemon/utils.py 2012-11-28 00:10:36 +0000
30+++ ubuntuone/syncdaemon/utils.py 2015-09-20 00:25:29 +0000
31@@ -33,7 +33,13 @@
32
33 from twisted.python import procutils
34
35-from dirspec.utils import get_program_path
36+try:
37+ from dirspec.utils import get_program_path
38+except ImportError:
39+ get_program_path = (
40+ lambda exe_name, **kw: os.path.abspath(
41+ os.path.join(os.path.curdir, 'bin', exe_name)))
42+
43
44 SYNCDAEMON_EXECUTABLE = 'ubuntuone-syncdaemon'
45 TUNNEL_EXECUTABLE = 'ubuntuone-proxy-tunnel'

Subscribers

People subscribed via source and target branches

to all changes: