Merge lp:~naesten/bzr-fastimport/400960-heredocs into lp:~bzr/bzr-fastimport/fastimport.dev

[Samuel Bronson]

[Samuel Bronson (naesten)]

Apologies to Onyx, I got wires crossed when trying to request Ian Clatworthy to review this :-(

[Samuel Bronson (naesten)]

> Apologies to Onyx, I got wires crossed when trying to request Ian Clatworthy
> to review this :-(

Er. S/Onyx/Oxyd/. (If you're wondering how I got the wires crossed, Ian's IRC nick is Oxyd's launchpad username.)

[Ian Clatworthy (ian-clatworthy)]

Thanks. Merged into trunk rev 183.

review: Approve

=== modified file 'parser.py'
--- parser.py	2009-04-14 03:47:51 +0000
+++ parser.py	2009-07-18 23:09:23 +0000
@@ -88,7 +88,8 @@
 
     # note: delim may be any string but must not contain lf.
     # data_line may contain any data but must not be exactly
-    # delim.
+    # delim. The lf after the final data_line is included in
+    # the data.
   delimited_data ::= 'data' sp '<<' delim lf
     (data_line lf)*
     delim lf;
@@ -234,7 +235,16 @@
 
         :return: the bytes read up to but excluding the terminator.
         """
-        raise NotImplementedError(self.read_until)
+        
+        lines = []
+        term = terminator + '\n'
+        while True:
+            line = self.input.readline()
+            if line == term:
+                break
+            else:
+                lines.append(line)
+        return ''.join(lines)
 
 
 # Regular expression used for parsing. (Note: The spec states that the name

=== modified file 'tests/test_parser.py'
--- tests/test_parser.py	2009-04-06 20:56:27 +0000
+++ tests/test_parser.py	2009-07-18 23:07:37 +0000
@@ -101,6 +101,14 @@
 committer <[e-mail]> now
 data 20
 first commit, empty
+# Test a commit with a heredoc-style (delimited_data) messsage (bug #400960)
+commit refs/heads/master
+mark :4
+author <[e-mail]> now
+committer <[e-mail]> now
+data <<EOF
+Commit with heredoc-style message
+EOF
 """
 
 
@@ -115,7 +123,7 @@
             if cmd.name == 'commit':
                 for fc in cmd.file_iter():
                     result.append(fc)
-        self.assertEqual(len(result), 10)
+        self.assertEqual(len(result), 11)
         cmd1 = result.pop(0)
         self.assertEqual('progress', cmd1.name)
         self.assertEqual('completed', cmd1.message)
@@ -178,6 +186,10 @@
         self.assertEqual('commit', cmd.name)
         self.assertEqual('3', cmd.mark)
         self.assertEqual(None, cmd.from_)
+        cmd = result.pop(0)
+        self.assertEqual('commit', cmd.name)
+        self.assertEqual('4', cmd.mark)
+        self.assertEqual('Commit with heredoc-style message\n', cmd.message)
 
 
 class TestStringParsing(tests.TestCase):