lp:~nacc/curtin/iscsi-test-fixes

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

471. By Nish Aravamudan on 2017-02-24

Store temporary YAML in logs/.

470. By Ryan Harper on 2017-02-22

vmtest: allow time-based skipping of tests, apply to ZestyMdadmBcache

Zesty kernel has broken bcache device names, tracked in LP: #1667078.
Allow vmtest to skip known broken tests for a period of time, raising
SkipTest from now() till some future date. Also, raise an exception if
we're skipping the test past a second date.

469. By Nish Aravamudan on 2017-02-22

Add iSCSI disk support.

iSCSI disks are specified following RFC4173
(https://tools.ietf.org/html/rfc4173) as:

  path: iscsi:[user:pass[:iuser:ipass]@]host:proto:port:lun:targetname

Unittests for iSCSI target parsing have been added as well as a vmtests
for testing iSCSI targets via tgt with all possible authentication
combinations.

For standalone testing, tools/find-tgt has been added to spawn a tgt
server as a regular user for serving iSCSI disks.

tools/jenkins-runner has been updated to use tools/find-tgt for the
automated vmtests.

Additionally, we add two new subcommands for working with iscsi volumes:
 block-attach-iscsi
 block-detach-iscsi

468. By Ryan Harper on 2017-02-22

vmtest: handle change in btrfs-progs when finding fs UUID.

Refactor how we extract the btrfs filesystem UUID with btrfs-progs tools.

LP: #1665701

467. By Scott Moser on 2017-02-13

pycodestyle: fix bare except in vmtests

The tox target tip-pycodestyle raises raises exception any time
you use a bare except.

This change here actually is much less forgiving, and will let an
exception raise if there is invalid json in the log file.

466. By Scott Moser on 2017-02-10

unittests: add subp coverage for retries, and rcs

This adds unit tests that verify correct behavior of subp with
   test_rcs_not_in_list_raise : subp(["sh", "-c", "exit 1"], rcs=[8])
   test_rcs_other_than_zero_work: subp(["sh", "-c", "exit 8"], rcs=[8])
   test_retry_none_does_not_retry: subp(["false"], retries=None)
   test_retry_does_retry: subp(["pass-on-try-2", retries=[1,0])

465. By Scott Moser on 2017-02-10

reporting: Add better descriptions and granularity of events

Add more human readable descriptions to the events and increase the number
of events we report to provide greater context in what's occurring during
a curtin install.

Add webhook reporting to all vmtests, including a unittest to catch if
curtin sends the install log to the webservice.

Refactor the in-tree webhook logger to be used as a module for use in
vmtest.

Add tools/curtin-log-print to pretty-print curtin install logs with custom
formatter and sorter.

464. By Scott Moser on 2017-02-10

tox: do not bother with pep8 from trusty in trusty-check

Following onto Josh's commit that removes style checking other than
the versions we have in trunk, there is no reason to run trusty
level pep8 any more in 'trusty-check'

463. By Joshua Powers on 2017-02-10

tests: add two scripts used for running vmtest with installed package.

Using vmtest to test a distro-installed curtin can be done by setting
CURTIN_VMTEST_CURTIN_EXE as described in doc/topics/integration-testing.rst.
This adds a helper for building a container with curtin in it,
and one for running 'curtin' inside that container.

vmtest can then use the curtin inside the container with:
 CURTIN_VMTEST_CURTIN_EXE="curtin-from-container container curtin" \
    ./tools/jenkins-runner

462. By Ryan Harper on 2017-02-10

Make add-apt-repository command retry

We see transient failures in overnight runs where add-apt-repository
fails to connect to the launchpad for network reasons. Handle this by
allowing our calls to be retried.