Code review comment for lp:~n-muench/ubuntu/precise/open-vm-tools/open-vm-tools-precise.sid-merge1

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Looking at the diffs between sid and your proposal, and between precise and your proposal, it looks good, thanks. Just two comments:

1. Please keep the changelog entries from unstable from between the current precise up to the latest unstable version, in the new changelog.

2. I'm curious why debian doesn't pass -Xusr/sbin/vmware-user-suid-wrapper to dh_fixperms. It seems right that we do. Is there a reason why they don't need to, or would it be appropriate to file a bug against the debian package to add it?

thanks again.

« Back to merge proposal