Code review comment for lp:~n-muench/ubuntu/precise/open-vm-tools/open-vm-tools-precise.sid-merge1

Revision history for this message
James Page (james-page) wrote :

Hi Nate

Thanks for preparing this MP; I've reviewed and it looks good.

I only have one comment which is about the package version number; I don't think this is technically a merge as you are really re-syncing the package changes and not including the Debian upstream changelog entries inbetween ubuntu changelog entries so I think the use of -1ubuntu1 is a little misleading and inconsistent with early re-syncs of the packaging.

Please could you update to use a 0ubuntu1 package version.

Thanks

James

review: Needs Fixing

« Back to merge proposal