Merge lp:~mzanetti/unity8/unity8-clickable-bottom-edge-hint into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 1859
Merged at revision: 1879
Proposed branch: lp:~mzanetti/unity8/unity8-clickable-bottom-edge-hint
Merge into: lp:unity8
Diff against target: 21 lines (+12/-0)
1 file modified
qml/Dash/Dash.qml (+12/-0)
To merge this branch: bzr merge lp:~mzanetti/unity8/unity8-clickable-bottom-edge-hint
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+265019@code.launchpad.net

Commit message

allow opening the manage dash area by clicking with a mouse on the arrow label

This is meant to be temporary and will be replaced with the upcoming bottom edge
component in the UITK.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

no

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

nope

 * If you changed the UI, has there been a design review?

Only changes behavior with mouse interaction. this is meant to be temporary. after talking to design it seems we will get a bottom-edge component in the UITK soon.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

qmltestrunner.Dash::test_close_temp_scope_preview_opening_scope
qmltestrunner.Dash::test_manage_dash_move_current

seem to have regressed. Can you check them?

review: Needs Fixing
1859. By Michael Zanetti

disable the MulitpointTouchArea when the Parent is disabled

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass?
As much as possible

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Dash/Dash.qml'
2--- qml/Dash/Dash.qml 2015-05-18 23:04:12 +0000
3+++ qml/Dash/Dash.qml 2015-07-17 10:45:10 +0000
4@@ -332,6 +332,18 @@
5 // Eat direct presses on the overview hint so that they do not end up in the card below
6 anchors.fill: parent
7 enabled: parent.opacity != 0
8+
9+ // TODO: This is a temporary workaround to allow people opening the
10+ // dash overview when there's no touch input around. Will be replaced with
11+ // a SDK component once that's available
12+ onClicked: bottomEdgeController.progress = 1;
13+
14+ // We need to eat touch events here in order to not allow opening the bottom edge with a touch press
15+ MultiPointTouchArea {
16+ anchors.fill: parent
17+ mouseEnabled: false
18+ enabled: parent.enabled
19+ }
20 }
21 }
22

Subscribers

People subscribed via source and target branches