Unity 8

Merge lp:~mzanetti/unity8/unfocus-drawers-textfield-on-move into lp:unity8

  1. unfocus-drawers-textfield-on-move
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 2843
Merged at revision: 2885
Proposed branch: lp:~mzanetti/unity8/unfocus-drawers-textfield-on-move
Merge into: lp:unity8
Diff against target: 29 lines (+8/-0)
2 files modified
qml/Launcher/Drawer.qml (+1/-0)
qml/Launcher/Launcher.qml (+7/-0)
To merge this branch: bzr merge lp:~mzanetti/unity8/unfocus-drawers-textfield-on-move
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
Unity8 CI Bot continuous-integration Approve
Review via email: mp+319456@code.launchpad.net

Commit message

unfocus the drawer's textfield when it is moved

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
no
 * Did you perform an exploratory manual test run of your code change and any related functionality?
yes
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
n/a

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2841
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3325/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4375
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2619
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2619
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4403
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4236
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4236/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4236
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4236/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4236
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4236/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4236
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4236/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4236
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4236/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4236
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4236/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3325/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Tests have regressed

review: Needs Fixing
lp:~mzanetti/unity8/unfocus-drawers-textfield-on-move updated
2842. By Michael Zanetti

remember focus state

2843. By Michael Zanetti

add a comment

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> Tests have regressed

should be fixed now

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2843
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3345/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4400
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2634
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2634
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4428
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4261
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4261/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4261
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4261/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4261
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4261/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4261
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4261/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4261
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4261/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4261
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4261/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3345/rebuild

review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Launcher/Drawer.qml'
2--- qml/Launcher/Drawer.qml 2017-01-26 15:12:21 +0000
3+++ qml/Launcher/Drawer.qml 2017-03-13 12:22:30 +0000
4@@ -27,6 +27,7 @@
5
6 property int panelWidth: 0
7 readonly property bool moving: listLoader.item && listLoader.item.moving
8+ readonly property Item searchTextField: searchField
9
10 signal applicationSelected(string appId)
11
12
13=== modified file 'qml/Launcher/Launcher.qml'
14--- qml/Launcher/Launcher.qml 2017-02-16 13:46:11 +0000
15+++ qml/Launcher/Launcher.qml 2017-03-13 12:22:30 +0000
16@@ -359,6 +359,13 @@
17 topMargin: root.inverted ? root.topPanelHeight : 0
18 bottom: parent.bottom
19 right: parent.left
20+ onRightMarginChanged: {
21+ // Remove (and put back) the focus for the searchfield in
22+ // order to hide the copy/paste popover when we move the drawer
23+ var hadFocus = drawer.searchTextField.focus;
24+ drawer.searchTextField.focus = false;
25+ drawer.searchTextField.focus = hadFocus;
26+ }
27 }
28 width: Math.min(root.width, units.gu(90)) * .9
29 panelWidth: panel.width

Subscribers

People subscribed via source and target branches