Merge lp:~mzanetti/unity8/stabilize-swipeAwayGreeter into lp:unity8
Proposed by
Michael Zanetti
Status: | Merged |
---|---|
Approved by: | Daniel d'Andrada |
Approved revision: | 2203 |
Merged at revision: | 2249 |
Proposed branch: | lp:~mzanetti/unity8/stabilize-swipeAwayGreeter |
Merge into: | lp:unity8 |
Prerequisite: | lp:~dandrader/unity8/removeUnusedTestCode |
Diff against target: |
19 lines (+1/-1) 1 file modified
tests/qmltests/tst_Shell.qml (+1/-1) |
To merge this branch: | bzr merge lp:~mzanetti/unity8/stabilize-swipeAwayGreeter |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Peeters (community) | Needs Information | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Daniel d'Andrada (community) | Approve | ||
Review via email: mp+286190@code.launchpad.net |
Commit message
stabilize swipeAwayGreeter()
so far it was only used after loadShell() which calls
waitForGreeterT
so let's call that on our own in swipeAwayGreeter();
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
there's a prereq
* Did you perform an exploratory manual test run of your code change and any related functionality?
yes
* Did you make sure that your branch does not contain spurious tags?
yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
* If you changed the UI, has there been a design review?
n/a
To post a comment you must log in.
Then can you please remove the explicit waitForGreeterT oStabilize( ) call from there?
""" pHasActiveFocus (data) {
loadShell( data.formFactor );
shell. usageScenario = data.usageScenario;
waitForGre eterToStabilize ();
swipeAwayG reeter( );
function test_launchedAp
"""