Merge lp:~mzanetti/unity8/rotate-dash into lp:unity8
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Michael Zanetti on 2016-04-27 | ||||||||
| Approved revision: | 2334 | ||||||||
| Merged at revision: | 2365 | ||||||||
| Proposed branch: | lp:~mzanetti/unity8/rotate-dash | ||||||||
| Merge into: | lp:unity8 | ||||||||
| Diff against target: |
8 lines (+0/-1) 1 file modified
data/unity8-dash.desktop.in (+0/-1) |
||||||||
| To merge this branch: | bzr merge lp:~mzanetti/unity8/rotate-dash | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel d'Andrada (community) | Needs Fixing on 2016-04-27 | ||
| Lukáš Tinkl (community) | 2016-04-20 | Approve on 2016-04-25 | |
| Unity8 CI Bot | continuous-integration | Needs Fixing on 2016-04-20 | |
|
Review via email:
|
|||
Commit Message
Drop the rotation lock for the dash
Description of the Change
Everyone thinks it's a bug and it really should rotate. Design agrees but there is no point in waiting for the next dash rework spec to be finalized just to enable this. I've had it enabled for a while on my device and it seems to behave well.
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
yes
* Did you make sure that your branch does not contain spurious tags?
yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
no
* If you changed the UI, has there been a design review?
Yes, Paty acked it.
| Daniel d'Andrada (dandrader) wrote : | # |
We should update the mock dash accordingly (make it rotate as well). Might break some tests relying on a non-rotating dash, so have to run them to make sure.
| Daniel d'Andrada (dandrader) wrote : | # |
> We should update the mock dash accordingly (make it rotate as well). Might
> break some tests relying on a non-rotating dash, so have to run them to make
> sure.
And update such tests as well, if needed.
| Michael Zanetti (mzanetti) wrote : | # |
This branch is in a silo that's already about to be handed off to QA. I'll update the mock in another branch. We really want to get this to the users in OTA-11
FAILED: Continuous integration, rev:2334
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/