lp:~mzanetti/unity8/refocus-dash-on-app-crash
- Get this branch:
- bzr branch lp:~mzanetti/unity8/refocus-dash-on-app-crash
Branch merges
- Michael Zanetti (community): Disapprove
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Gerry Boland (community): Approve
- Michał Sawicz: Needs Fixing
-
Diff: 84 lines (+33/-2)4 files modifiedqml/Shell.qml (+5/-0)
tests/mocks/Unity/Application/ApplicationManager.cpp (+15/-1)
tests/mocks/Unity/Application/ApplicationManager.h (+2/-1)
tests/qmltests/tst_Shell.qml (+11/-0)
Branch information
Recent revisions
- 1351. By Michael Zanetti
-
scale down errorText label if necessary Fixes: 1378848
Approved by: Michael Terry - 1350. By Michael Terry
-
Fix some security issues with the tablet greeter, which allowed the lockscreen to be bypassed. (LP: #1367715)
Recent greeter fixes for phone mode did not fully take the tablet scenario into account. This branch does three main things:
1) Rename fakeActiveForApp because it is nothing but confusing. I renamed the variable itself to lockedApp and added a new variable hasLockedApp, which is infinitely clearer than fakeActiveForApp !== "", which is what we used to use. Since that is a very security-sensitive variable, I figured it's best to be clear.
2) Closed a security bug where if the user could plug in a phone showing the emergency dialer to a bigger screen, thus switching to tablet mode, they could get access to other apps.
3) Closed a security bug where the tablet lockscreen could be left-swiped away.
4) Closed a security bug where the tablet would unlock itself if you launched an app from the indicators or launcher. Now it just focuses the prompt field (much like how the phone shows the lockscreen pin pad). Fixes: 1367715
Approved by: Michael Zanetti
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:unity8