Merge lp:~mzanetti/unity8/previewcommentinput into lp:unity8
Status: | Superseded |
---|---|
Proposed branch: | lp:~mzanetti/unity8/previewcommentinput |
Merge into: | lp:unity8 |
Diff against target: |
212 lines (+170/-0) 5 files modified
qml/Dash/Previews/PreviewCommentInput.qml (+82/-0) qml/Dash/Previews/PreviewWidgetFactory.qml (+1/-0) tests/qmltests/CMakeLists.txt (+1/-0) tests/qmltests/Dash/Previews/tst_PreviewCommentInput.qml (+85/-0) tests/qmltests/Dash/Previews/tst_PreviewWidgetFactory.qml (+1/-0) |
To merge this branch: | bzr merge lp:~mzanetti/unity8/previewcommentinput |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Andrea Cimitan (community) | Needs Fixing | ||
Review via email: mp+260719@code.launchpad.net |
This proposal has been superseded by a proposal from 2015-06-25.
Commit message
Implements a comment input widget
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
yes
* Did you make sure that your branch does not contain spurious tags?
yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
* If you changed the UI, has there been a design review?
added a new component as per visual spec.
* Did you have a look at the warnings when running tests? Can they be reduced?
yes. only the old Theme.palette thing.
PASSED: Continuous integration, rev:1795 jenkins. qa.ubuntu. com/job/ unity8- ci/5788/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- wily-touch/ 67 jenkins. qa.ubuntu. com/job/ unity8- wily-amd64- ci/66 jenkins. qa.ubuntu. com/job/ unity8- wily-i386- ci/66 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- wily-mako/ 53 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- wily-armhf/ 67 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- wily-armhf/ 67/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 20869
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/5788/ rebuild
http://