Unity 8

Merge lp:~mzanetti/unity8/patched-control into lp:unity8

  1. patched-control
  2. Merge into trunk
Proposed by Michael Zanetti on 2015-01-12
Status: Merged
Approved by: Michał Sawicz on 2015-01-12
Approved revision: 1547
Merged at revision: 1550
Proposed branch: lp:~mzanetti/unity8/patched-control
Merge into: lp:unity8
Diff against target: 15 lines (+4/-1)
1 file modified
build.sh (+4/-1)
To merge this branch: bzr merge lp:~mzanetti/unity8/patched-control
Reviewer Review Type Date Requested Status
Michał Sawicz 2015-01-12 Approve on 2015-01-12
PS Jenkins bot continuous-integration Needs Fixing on 2015-01-12
Review via email: mp+246105@code.launchpad.net

Commit Message

patch debian/control file before using it to make it work with mk-build-deps

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

no

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

 * If you changed the UI, has there been a design review?

n/a

To post a comment you must log in.
Michał Sawicz (saviq) :
review: Needs Fixing
lp:~mzanetti/unity8/patched-control updated on 2015-01-12
1546. By Michael Zanetti on 2015-01-12

change it a bit

PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1545
http://jenkins.qa.ubuntu.com/job/unity8-ci/5135/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/767
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/299
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/300
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/300
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/667
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/765
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/765/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16994

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5135/rebuild

review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1546
http://jenkins.qa.ubuntu.com/job/unity8-ci/5137/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/769
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/301
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/302
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/302
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/669
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/767
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/767/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16997

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5137/rebuild

review: Needs Fixing (continuous-integration)
Michał Sawicz (saviq) :
review: Needs Fixing
lp:~mzanetti/unity8/patched-control updated on 2015-01-12
1547. By Michael Zanetti on 2015-01-12

check on the control file, not the .deb package

Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Y
 * Did CI run pass? If not, please explain why.
Unrelated fail :/
 * Did you make sure that the branch does not contain spurious tags?
Y

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build.sh'
2--- build.sh 2014-11-14 17:47:00 +0000
3+++ build.sh 2015-01-12 15:50:34 +0000
4@@ -61,7 +61,10 @@
5 }
6
7 mk_build_deps() {
8- [ ! -f unity8-build-deps*deb -o $CODE_DIR/debian/control -nt unity8-build-deps*deb ] && mk-build-deps --install --root-cmd sudo $CODE_DIR/debian/control
9+ if [ ! -f control -o $CODE_DIR/debian/control -nt control ]; then
10+ sed 's/\:native//g' $CODE_DIR/debian/control > control
11+ mk-build-deps --install --root-cmd sudo control
12+ fi
13 }
14
15 if [ -f "/usr/bin/ccache" ] ; then

Subscribers

People subscribed via source and target branches