Merge lp:~mzanetti/unity8/new-pageheader-api into lp:unity8

[Michael Zanetti]

Update PageHeader to use new SDK api

* Are there any related MPs required for this MP to build/function as expected? Please list.

!!!! Do not land until timp approves. He'll land the SDK related change !!!!
https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/separatorOff/+merge/239217 (needs to land before, not necessarily at the same time)

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

 * If you changed the UI, has there been a design review?

n/a

[lp:~mzanetti/unity8/new-pageheader-api]

1371. By Michael Zanetti on 2014-10-22

reorder

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1371
http://jenkins.qa.ubuntu.com/job/unity8-ci/4740/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6140
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1726
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1836
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1834
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5767
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7392
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7392/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14970

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4740/rebuild

review: Needs Fixing (continuous-integration)

[Tim Peeters (tpeeters)]

we landed the prerequisite in vivid, so this one is also ready to go!

review: Approve

=== modified file 'qml/Dash/PageHeader.qml'
--- qml/Dash/PageHeader.qml	2014-09-30 10:46:50 +0000
+++ qml/Dash/PageHeader.qml	2014-10-22 17:20:54 +0000
@@ -170,7 +170,7 @@
                 height: headerContainer.height
                 contentHeight: height
                 opacity: headerContainer.clip || headerContainer.showSearch ? 1 : 0 // setting visible false cause column to relayout
-                separatorSource: ""
+                __separator_visible: false
                 // Required to keep PageHeadStyle noise down as it expects the Page's properties around.
                 property var styledItem: searchHeader
                 property string title
@@ -241,8 +241,7 @@
                 height: headerContainer.height
                 contentHeight: height
                 opacity: headerContainer.clip || !headerContainer.showSearch ? 1 : 0 // setting visible false cause column to relayout
-                separatorSource: ""
-                separatorBottomSource: ""
+                __separator_visible: false
                 property var styledItem: header
                 property string title: root.title
                 property var config: PageHeadConfiguration {