Merge lp:~mzanetti/unity8/launcher-updates into lp:unity8
| Status: | Superseded |
|---|---|
| Proposed branch: | lp:~mzanetti/unity8/launcher-updates |
| Merge into: | lp:unity8 |
| Diff against target: |
2110 lines (+941/-125) 28 files modified
CMakeLists.txt (+1/-1) debian/control (+3/-3) plugins/AccountsService/AccountsService.cpp (+54/-0) plugins/AccountsService/AccountsService.h (+8/-0) qml/Components/EdgeBarrier.qml (+1/-1) qml/Components/PhysicalKeysMapper.qml (+24/-0) qml/Launcher/Launcher.qml (+113/-3) qml/Launcher/LauncherDelegate.qml (+46/-8) qml/Launcher/LauncherPanel.qml (+103/-32) qml/Launcher/graphics/launcher-app-focus-ring.svg (+12/-0) qml/Shell.qml (+33/-0) qml/Stages/ApplicationWindow.qml (+8/-0) qml/Stages/DecoratedWindow.qml (+8/-0) qml/Stages/DesktopSpread.qml (+59/-16) qml/Stages/DesktopSpreadDelegate.qml (+15/-1) qml/Stages/DesktopStage.qml (+40/-23) qml/Stages/SurfaceContainer.qml (+36/-1) tests/mocks/AccountsService/AccountsService.cpp (+17/-0) tests/mocks/AccountsService/AccountsService.h (+8/-0) tests/mocks/Unity/Application/MirSurface.cpp (+15/-1) tests/mocks/Unity/Application/MirSurface.h (+6/-0) tests/mocks/Unity/Launcher/MockLauncherModel.cpp (+2/-0) tests/plugins/AccountsService/PropertiesServer.cpp (+10/-1) tests/plugins/AccountsService/PropertiesServer.h (+0/-1) tests/plugins/AccountsService/client.cpp (+29/-0) tests/qmltests/Launcher/tst_Launcher.qml (+147/-5) tests/qmltests/Stages/tst_DesktopStage.qml (+29/-3) tests/qmltests/tst_Shell.qml (+114/-25) |
| To merge this branch: | bzr merge lp:~mzanetti/unity8/launcher-updates |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lukáš Tinkl (community) | 2015-11-25 | Approve on 2016-02-12 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2016-02-02 | |
| Albert Astals Cid (community) | Abstain on 2016-02-02 | ||
| Unity8 CI Bot | continuous-integration | Approve on 2016-01-14 | |
| Andrea Cimitan (community) | Needs Information on 2015-12-08 | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2016-02-17.
Commit Message
Implement Launcher's keyboard navigation and updated pip design
Description of the Change
This implements the launcher design updates as specified in the Trello card with one exception. The launcher's width changes have been revised by design by now. We're gonna keep it it 8gu wide by default.
* Are there any related MPs required for this MP to build/function as expected? Please list.
n
* Did you perform an exploratory manual test run of your code change and any related functionality?
y
* Did you make sure that your branch does not contain spurious tags?
y
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
* If you changed the UI, has there been a design review?
yes
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2049
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Lukáš Tinkl (lukas-kde) wrote : | # |
qmltestrunner.
qmltestrunner.
qmltestrunner.
qmltestrunner.
qmltestrunner.
qmltestrunner.
qmltestrunner.
qmltestrunner.
qmltestrunner.
qmltestrunner.
There are tests failing (could reproduce the failures locally as well)
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2050
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2057
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2060
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Lukáš Tinkl (lukas-kde) wrote : | # |
Code looks good, works perfectly and tests finally passing, approving
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
Yes (modulo xenial)
* Did you make sure that the branch does not contain spurious tags?
Yes
| Michael Zanetti (mzanetti) wrote : | # |
> minor thing
replied/fixed
| Albert Astals Cid (aacid) wrote : | # |
Note for later: This was already top approved.
Text conflict in tests/qmltests/
1 conflicts encountered.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2062
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Michael Zanetti (mzanetti) wrote : | # |
> Note for later: This was already top approved.
>
> Text conflict in tests/qmltests/
> 1 conflicts encountered.
merged
| Lukáš Tinkl (lukas-kde) wrote : | # |
Still under review, hold on a bit :)
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2063
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2064
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Lukáš Tinkl (lukas-kde) wrote : | # |
Re-approving after keyboard shortcut and test fixes
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
Yes (modulo xenial)
* Did you make sure that the branch does not contain spurious tags?
Yes
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2065
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
Text conflict in qml/Launcher/
1 conflicts encountered
Was already top approved.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2068
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Michael Zanetti (mzanetti) wrote : | # |
> Text conflict in qml/Launcher/
> 1 conflicts encountered
>
> Was already top approved.
merged
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2069
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
Actually
make xvfbtestLauncher FUNCTION=
seems to consistently fail in this branch for me while it works on trunk, can you have a look?
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
PASSED: Continuous integration, rev:2069
https:/
Executed test runs:
Click here to trigger a rebuild:
https:/
| Michael Zanetti (mzanetti) wrote : | # |
> Actually
>
> make xvfbtestLauncher FUNCTION=
>
> seems to consistently fail in this branch for me while it works on trunk, can
> you have a look?
fixed. the test was clicking on the new UI elements instead of the empty space. I fixed this already some few weeks ago but seems some branch reverted the fix in the meantime again and in trunk it's only clicking between the control layouts by luck...
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2070
https:/
Executed test runs:
Click here to trigger a rebuild:
https:/
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2070
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2071
https:/
Executed test runs:
Click here to trigger a rebuild:
https:/
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2071
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
PASSED: Continuous integration, rev:2072
https:/
Executed test runs:
Click here to trigger a rebuild:
https:/
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2072
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Lukáš Tinkl (lukas-kde) wrote : | # |
Works (and looks) fine now with the other launcher-sizing branch, approving
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
Yes (minus some unrelated xenial failures, passes locally xenial just fine)
* Did you make sure that the branch does not contain spurious tags?
Yes
| Albert Astals Cid (aacid) wrote : | # |
Note this was already top-approved, re-approve after merge
Text conflict in qml/Components/
1 conflicts encountered.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2073
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 2075. By Michael Zanetti on 2016-02-12
-
merge silo 51 as prereq
- 2076. By Michael Zanetti on 2016-02-17
-
merge trunk
- 2077. By Michael Zanetti on 2016-02-25
-
fix an issue where the highlight might not be removed after launching

Please add a little test for the Alt+F1 and arrow keys functionality