Merge lp:~mzanetti/unity8/launcher-update-home-button-design into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Michał Sawicz
Approved revision: 982
Merged at revision: 1034
Proposed branch: lp:~mzanetti/unity8/launcher-update-home-button-design
Merge into: lp:unity8
Prerequisite: lp:~mzanetti/unity8/launcher-new-background
Diff against target: 21 lines (+3/-2)
1 file modified
qml/Launcher/LauncherPanel.qml (+3/-2)
To merge this branch: bzr merge lp:~mzanetti/unity8/launcher-update-home-button-design
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michał Sawicz Approve
Vesa Rautiainen Pending
Andrea Cimitan Pending
Review via email: mp+226200@code.launchpad.net

This proposal supersedes a proposal from 2014-06-23.

Commit message

Update Launcher's home button design according to new spec.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

no

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

no

 * If you changed the UI, has there been a design review?

design review requested

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Vesa Rautiainen (vesar) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote : Posted in a previous version of this proposal

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
Unrelated

review: Approve
Revision history for this message
Michał Sawicz (saviq) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Launcher/LauncherPanel.qml'
2--- qml/Launcher/LauncherPanel.qml 2014-07-09 19:31:06 +0000
3+++ qml/Launcher/LauncherPanel.qml 2014-07-09 19:31:06 +0000
4@@ -47,7 +47,9 @@
5 Rectangle {
6 width: parent.width
7 height: units.gu(7)
8- color: "#de4814"
9+ color: UbuntuColors.orange
10+ z: 1
11+
12 Image {
13 objectName: "dashItem"
14 width: units.gu(5)
15@@ -60,7 +62,6 @@
16 id: dashItem
17 anchors.fill: parent
18 onClicked: root.showDashHome()
19- z: 1
20 }
21 }
22

Subscribers

People subscribed via source and target branches