Merge lp:~mzanetti/unity8/launcher-quicklist-wording into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Michał Sawicz
Approved revision: 978
Merged at revision: 1005
Proposed branch: lp:~mzanetti/unity8/launcher-quicklist-wording
Merge into: lp:unity8
Diff against target: 21 lines (+2/-2)
1 file modified
plugins/Unity/Launcher/launcheritem.cpp (+2/-2)
To merge this branch: bzr merge lp:~mzanetti/unity8/launcher-quicklist-wording
Reviewer Review Type Date Requested Status
Ying-Chun Liu (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Vesa Rautiainen Pending
Review via email: mp+224096@code.launchpad.net

Commit message

change wording in launcher quicklist

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

No

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

no

 * If you changed the UI, has there been a design review?

design review requested

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ying-Chun Liu (paulliu) wrote :

Tested. Good.

review: Approve
Revision history for this message
Ying-Chun Liu (paulliu) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.

 * Did CI run pass? If not, please explain why.

No. Don't know why.

Revision history for this message
Michał Sawicz (saviq) wrote :

All the failures were known and are fixed in trunk now (except for the Shell one).

979. By Michael Zanetti

merge trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/Unity/Launcher/launcheritem.cpp'
2--- plugins/Unity/Launcher/launcheritem.cpp 2014-06-11 15:36:51 +0000
3+++ plugins/Unity/Launcher/launcheritem.cpp 2014-07-01 10:44:21 +0000
4@@ -40,7 +40,7 @@
5 m_quickList->appendAction(nameAction);
6 QuickListEntry pinningAction;
7 pinningAction.setActionId("pin_item");
8- pinningAction.setText(gettext("Lock to Launcher"));
9+ pinningAction.setText(gettext("Pin shortcut"));
10 m_quickList->appendAction(pinningAction);
11 }
12
13@@ -70,7 +70,7 @@
14 m_pinned = pinned;
15 QuickListEntry entry;
16 entry.setActionId("pin_item");
17- entry.setText(pinned ? gettext("Unlock from Launcher") : gettext("Lock to Launcher"));
18+ entry.setText(pinned ? gettext("Unpin shortcut") : gettext("Pin shortcut"));
19 m_quickList->updateAction(entry);
20 Q_EMIT pinnedChanged(pinned);
21 }

Subscribers

People subscribed via source and target branches