Merge lp:~mzanetti/unity8/launcher-new-dnd-indicator into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 978
Merged at revision: 1016
Proposed branch: lp:~mzanetti/unity8/launcher-new-dnd-indicator
Merge into: lp:unity8
Diff against target: 23 lines (+2/-1)
1 file modified
qml/Launcher/LauncherPanel.qml (+2/-1)
To merge this branch: bzr merge lp:~mzanetti/unity8/launcher-new-dnd-indicator
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+224110@code.launchpad.net

Commit message

make the launcher's drag'n'drop indicator more prominent

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

no

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

no

 * If you changed the UI, has there been a design review?

design review requested

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Launcher/LauncherPanel.qml'
2--- qml/Launcher/LauncherPanel.qml 2013-12-11 12:57:14 +0000
3+++ qml/Launcher/LauncherPanel.qml 2014-06-23 11:38:22 +0000
4@@ -168,6 +168,7 @@
5 anchors.centerIn: parent
6 width: parent.width + mainColumn.anchors.leftMargin + mainColumn.anchors.rightMargin
7 opacity: 0
8+ source: "graphics/divider-line.png"
9 }
10
11 states: [
12@@ -247,7 +248,7 @@
13 Transition {
14 from: "dragging"
15 to: "*"
16- NumberAnimation { target: dropIndicator; properties: "opacity"; duration: UbuntuAnimation.FastDuration }
17+ NumberAnimation { target: dropIndicator; properties: "opacity"; duration: UbuntuAnimation.SnapDuration }
18 NumberAnimation { properties: "itemOpacity"; duration: UbuntuAnimation.BriskDuration }
19 SequentialAnimation {
20 ScriptAction { script: if (index == launcherListView.count-1) launcherListView.flick(0, -launcherListView.clickFlickSpeed); }
21
22=== added file 'qml/Launcher/graphics/divider-line.png'
23Binary files qml/Launcher/graphics/divider-line.png 1970-01-01 00:00:00 +0000 and qml/Launcher/graphics/divider-line.png 2014-06-23 11:38:22 +0000 differ

Subscribers

People subscribed via source and target branches