Merge lp:~mzanetti/unity8/launcher-drop-spacing into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Ying-Chun Liu
Approved revision: 979
Merged at revision: 1003
Proposed branch: lp:~mzanetti/unity8/launcher-drop-spacing
Merge into: lp:unity8
Diff against target: 11 lines (+0/-1)
1 file modified
qml/Launcher/LauncherPanel.qml (+0/-1)
To merge this branch: bzr merge lp:~mzanetti/unity8/launcher-drop-spacing
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Ying-Chun Liu (community) Approve
Vesa Rautiainen (community) design review Approve
Review via email: mp+224094@code.launchpad.net

Commit message

drop launcher item spacing

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

No

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

no

 * If you changed the UI, has there been a design review?

design review requested

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ying-Chun Liu (paulliu) wrote :

Tested. Looks good.

review: Approve
979. By Michael Zanetti

merge trunk

Revision history for this message
Vesa Rautiainen (vesar) wrote :

Looks good

review: Approve (design review)
Revision history for this message
Ying-Chun Liu (paulliu) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.

 * Did CI run pass? If not, please explain why.
No.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Launcher/LauncherPanel.qml'
2--- qml/Launcher/LauncherPanel.qml 2013-12-11 12:57:14 +0000
3+++ qml/Launcher/LauncherPanel.qml 2014-07-01 10:39:13 +0000
4@@ -104,7 +104,6 @@
5 highlightRangeMode: ListView.ApplyRange
6 preferredHighlightBegin: (height - itemHeight) / 2
7 preferredHighlightEnd: (height + itemHeight) / 2
8- spacing: units.gu(0.5)
9
10 // The size of the area the ListView is extended to make sure items are not
11 // destroyed when dragging them outside the list. This needs to be at least

Subscribers

People subscribed via source and target branches