Unity 8

Merge lp:~mzanetti/unity8/launcher-dont-hide-on-focus into lp:unity8

  1. launcher-dont-hide-on-focus
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Michael Zanetti
Approved revision: 306
Merged at revision: 319
Proposed branch: lp:~mzanetti/unity8/launcher-dont-hide-on-focus
Merge into: lp:unity8
Diff against target: 12 lines (+1/-1)
1 file modified
Shell.qml (+1/-1)
To merge this branch: bzr merge lp:~mzanetti/unity8/launcher-dont-hide-on-focus
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Nicolas d'Offay (community) Approve
Review via email: mp+184741@code.launchpad.net

Commit message

Don't hide the launcher on changes in the stages.

Description of the change

Right now, when you launch an app and then quickly reveal the launcher while the app is still loading, the launcher will be hidden. This breaks usability and is not really needed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:306
http://jenkins.qa.ubuntu.com/job/unity8-ci/959/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3230
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/773
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1626
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/960
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/960/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/959
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3236
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3236/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2722
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/775
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/775/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/640
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/651

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/959/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:306
http://jenkins.qa.ubuntu.com/job/unity8-ci/960/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3232
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/775
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1627
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/961
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/961/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/960
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3238
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3238/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2724
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/777
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/777/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/642
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/653

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/960/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:306
http://jenkins.qa.ubuntu.com/job/unity8-ci/980/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3298
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/838
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1656
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/981
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/981/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/980
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3304
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3304/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2788
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/840
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/840/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/701
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/711

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/980/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:306
http://jenkins.qa.ubuntu.com/job/unity8-ci/984/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3302
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/842/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1660
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/985
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/985/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/984
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3308
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3308/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2792
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/844/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/984/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nicolas d'Offay (nicolas-doffay) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/433/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/generic-cleanup-mbs/2195
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3356
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/893
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1686
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-autolanding/14
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/432
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-autolanding/432/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-autolanding/433
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3364
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3364/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2834
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/895
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/895/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/743
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/753

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Shell.qml'
2--- Shell.qml 2013-09-10 08:10:10 +0000
3+++ Shell.qml 2013-09-10 09:26:22 +0000
4@@ -255,7 +255,7 @@
5 property bool fullyShown: shown && x == 0 && parent.x == 0
6 property bool fullyHidden: !shown && x == width
7 available: !greeter.shown
8- hides: [launcher, panel.indicators]
9+ hides: [panel.indicators]
10 shown: false
11 opacity: 1.0
12 showAnimation: StandardAnimation { property: "x"; duration: 350; to: 0; easing.type: Easing.OutCubic }

Subscribers

People subscribed via source and target branches