Merge into trunk : inputinfo-debug : Code : Unity 8

Status:	Merged
Approved by:	Michael Terry on 2015-12-07
Approved revision:	2077
Merged at revision:	2091
Proposed branch:	lp:~mzanetti/unity8/inputinfo-debug
Merge into:	lp:unity8
Diff against target:	20 lines (+3/-0) 1 file modified plugins/Unity/InputInfo/linux/qinputdeviceinfo_linux.cpp (+3/-0)
To merge this branch:	bzr merge lp:~mzanetti/unity8/inputinfo-debug
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Terry			Approve on 2015-12-07
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-12-04
Michał Sawicz		2015-12-01	Needs Fixing on 2015-12-04
Review via email: mp+279117@code.launchpad.net

Commit Message

add some debug prints to the uinput backend

this should make debugging bug reports easier

Description of the Change

* Are there any related MPs required for this MP to build/function as expected? Please list.
n
* Did you perform an exploratory manual test run of your code change and any related functionality?
not really, no
* Did you make sure that your branch does not contain spurious tags?
y
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
* If you changed the UI, has there been a design review?
n/a

PS Jenkins bot (ps-jenkins) wrote on 2015-12-01:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6855/rebuild

review: Needs Fixing (continuous-integration)

Michał Sawicz (saviq) wrote on 2015-12-04:

#

I'm not getting the "added" debug when connecting a keyboard, excerpt from (dis)connecting twice:

Input device removed: "Logitech Keyboard K480" "/dev/input/input7" QFlags(0x1|0x10)
Input device removed: "Logitech Keyboard K480" "/dev/input/input8" QFlags(0x1|0x10)

review: Needs Fixing

lp:~mzanetti/unity8/inputinfo-debug updated on 2015-12-04

2077. By Michael Zanetti on 2015-12-04: also print info when we cannot fetch full details

PS Jenkins bot (ps-jenkins) wrote on 2015-12-04:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/6885/rebuild

review: Needs Fixing (continuous-integration)

Michael Terry (mterry) wrote on 2015-12-07:

#

Works for me now.

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

* Did CI run pass? If not, please explain why.
No, but for unrelated reasons

* Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

1	=== modified file 'plugins/Unity/InputInfo/linux/qinputdeviceinfo_linux.cpp'
2	--- plugins/Unity/InputInfo/linux/qinputdeviceinfo_linux.cpp 2015-10-01 10:58:40 +0000
3	+++ plugins/Unity/InputInfo/linux/qinputdeviceinfo_linux.cpp 2015-12-04 19:48:44 +0000
4	@@ -159,6 +159,8 @@
5	}
6	eventPath = inputDevice->devicePath();
7
8	+ qDebug() << "Input device added:" << inputDevice->name() << inputDevice->devicePath() << inputDevice->type();
9	+
10	fd = open(eventPath.toLatin1(), O_RDONLY\|O_NONBLOCK);
11	if (fd == -1) {
12	return inputDevice;
13	@@ -205,6 +207,7 @@
14	// this path is not a full evdev path
15	Q_FOREACH (const QString devicePath, deviceMap.keys()) {
16	if (devicePath.contains(path)) {
17	+ qDebug() << "Input device removed:" << deviceMap.value(devicePath)->name() << devicePath << deviceMap.value(devicePath)->type();
18	deviceMap.remove(devicePath);
19	Q_EMIT deviceRemoved(devicePath);
20	}

Unity 8

Merge lp:~mzanetti/unity8/inputinfo-debug into lp:unity8

Commit Message

Description of the Change

Preview Diff

Subscribers