Merge lp:~mzanetti/unity8/indicators-mouse into lp:unity8

Proposed by Michael Zanetti
Status: Merged
Approved by: Daniel d'Andrada
Approved revision: 1620
Merged at revision: 1673
Proposed branch: lp:~mzanetti/unity8/indicators-mouse
Merge into: lp:unity8
Diff against target: 32 lines (+15/-0)
1 file modified
qml/Panel/IndicatorsMenu.qml (+15/-0)
To merge this branch: bzr merge lp:~mzanetti/unity8/indicators-mouse
Reviewer Review Type Date Requested Status
Daniel d'Andrada (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+250429@code.launchpad.net

Commit message

Add a mouse area to the indicators panel so we can open them by clicking.

The proper solution depends on designs we don't have yet. This should get us going with enabling mouse events without regressing for now.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

https://code.launchpad.net/~mir-team/qtmir/port-to-event-2.0/+merge/248067

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

 * If you changed the UI, has there been a design review?

Proper designs still WIP. This is a hotfix until we have those.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.

* Did CI run pass? If not, please explain why.
Yes! What a rare sight!

* Did you make sure that the branch does not contain spurious tags?
Yes.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Panel/IndicatorsMenu.qml'
2--- qml/Panel/IndicatorsMenu.qml 2014-11-11 15:28:13 +0000
3+++ qml/Panel/IndicatorsMenu.qml 2015-02-20 11:27:16 +0000
4@@ -162,6 +162,15 @@
5 onScroll: bar.addScrollOffset(scrollAmount);
6 }
7
8+ MouseArea {
9+ anchors.fill: __showDragHandle
10+ enabled: __showDragHandle.enabled
11+ onClicked: {
12+ bar.selectItemAt(mouseX)
13+ root.show()
14+ }
15+ }
16+
17 DragHandle {
18 id: __showDragHandle
19 anchors.bottom: parent.bottom
20@@ -182,6 +191,12 @@
21 hintDisplacement: enableHint ? expandedPanelHeight - minimizedPanelHeight + handle.height : 0
22 }
23
24+ MouseArea {
25+ anchors.fill: __hideDragHandle
26+ enabled: __hideDragHandle.enabled
27+ onClicked: root.hide()
28+ }
29+
30 DragHandle {
31 id: __hideDragHandle
32 anchors.fill: handle

Subscribers

People subscribed via source and target branches